From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v5] Add support for colored and styled underlines on tty frames Date: Sun, 10 Mar 2024 21:28:56 +0200 Message-ID: <86o7blvqbr.fsf@gnu.org> References: <20240211180501.695192-1-mohkale@kisara.moe> <87bk8m1mq8.fsf@yahoo.com> <87wmqaf1oy.fsf@kisara.moe> <86v85uugki.fsf@gnu.org> <87msr6vte8.fsf@kisara.moe> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2155"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, mohkale@kisara.moe, 62994@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 10 20:29:37 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjOrZ-0000PV-4g for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Mar 2024 20:29:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjOrS-0001Ht-0H; Sun, 10 Mar 2024 15:29:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjOrQ-0001Hk-UT for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 15:29:28 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjOrQ-00034y-ME for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 15:29:28 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rjOry-0002YD-2E for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 15:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Mar 2024 19:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.17100989809751 (code B ref 62994); Sun, 10 Mar 2024 19:30:02 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 10 Mar 2024 19:29:40 +0000 Original-Received: from localhost ([127.0.0.1]:37914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjOrb-0002XD-HM for submit@debbugs.gnu.org; Sun, 10 Mar 2024 15:29:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjOrZ-0002X0-UT for 62994@debbugs.gnu.org; Sun, 10 Mar 2024 15:29:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjOqx-00031t-6Y; Sun, 10 Mar 2024 15:28:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jM12CljonlXWNOqBjQY5dBEPGS8Ovw2TOdoc8hb1pb8=; b=j0T1flaG9Dne NDjPbNGj1GQjunXwITyEe9OW3B98I7jYyCEneY2Gm93A51j7CTfmR/0eboQ2rKLjPhAcX1PKyjNlg LubRuDpD2MkItJFyW9CK5pcxJAyhY7jS2CWMhSb56vjO3MadU8SAsIjKG/n96oLRX77BDUMIPa18r l4UO9e7vqCUpDVfc2thBA+OkRo6H4wRJwPBn5V2I7xlH0rQIMxa3lQyW98fpBJVdz3vT2r0FoBDUe sYXrsdi8ggvoTDz3RxSf7bc8ez9EnGsAj60EIsaKGF8E21ojSFUhpQFb9XfrUA3ESFiTNzYkSWUDM ZWqjj2NegCy8kYhEmvvIqg==; In-Reply-To: (message from Jim Porter on Sun, 10 Mar 2024 11:51:51 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281432 Archived-At: > Date: Sun, 10 Mar 2024 11:51:51 -0700 > Cc: luangruo@yahoo.com, 62994@debbugs.gnu.org > From: Jim Porter > > On 3/10/2024 11:22 AM, Mohsin Kaleem wrote: > > Eli Zaretskii writes: > > > >> The "+++" thingy means the manuals were updated for this change, which > >> is why Po Lu asked where are those updates. > > > > I see, does --- have a similar alternate meaning or can I just replace > > the pluses with minuses? > > "---" means there's no need to update the manuals for that change in NEWS. > > >> Not absolutely necessary, but very much preferred. It is unheard of > >> in Emacs to have some face attribute that is supported on TTY frames > >> but not on GUI frames. > > > > I see. If a blocker I'm happy to remove the extra underline styles? I'm > > not sure how long it would take me to add GUI support and as I don't use > > the GUI I'd be unlikely to prioritise it any time soon. > > If someone points me in the right direction, I could take a look (I'd > particularly like to use the dotted underlines in GUI frames). It'll > probably be a couple weeks at least until I could work on it though. Thanks. I'm not sure I understand where you want to be directed. Is it to the code which implements underwave on GUI frames? something else?