From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70093: Remove unnecessary `image-tests--map-equal' Date: Sun, 31 Mar 2024 10:33:53 +0300 Message-ID: <86o7auc0ta.fsf@gnu.org> References: <877chjcxfg.fsf@breatheoutbreathe.in> <86y19zaswg.fsf@gnu.org> <8734s7c6cv.fsf@breatheoutbreathe.in> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32059"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70093@debbugs.gnu.org, da_vid@orange.fr To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 31 09:35:41 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rqpjA-000843-QO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Mar 2024 09:35:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqpie-0003ZF-0V; Sun, 31 Mar 2024 03:35:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqpiW-0003RD-9A for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2024 03:35:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rqpiW-0002Tr-12 for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2024 03:35:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rqpiY-0006eq-0Y for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2024 03:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Mar 2024 07:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70093 X-GNU-PR-Package: emacs Original-Received: via spool by 70093-submit@debbugs.gnu.org id=B70093.171187045525416 (code B ref 70093); Sun, 31 Mar 2024 07:35:01 +0000 Original-Received: (at 70093) by debbugs.gnu.org; 31 Mar 2024 07:34:15 +0000 Original-Received: from localhost ([127.0.0.1]:46504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqphm-0006bp-Aq for submit@debbugs.gnu.org; Sun, 31 Mar 2024 03:34:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqphi-0006bS-S7 for 70093@debbugs.gnu.org; Sun, 31 Mar 2024 03:34:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqphZ-000246-On; Sun, 31 Mar 2024 03:34:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JaeCJE42Vy8nPYNwZSp+cH6U5BqlS58JmcKhC7kySpI=; b=nmlIU3OhL/oN mRKPJ+1RSk8QJM/miYAVkfa/WmN//x+vgLR98pHgaTcLqtJuMjtssrk8VrcuhcQMILXMdvA4EKIJ5 cJIP/vKGFOoR3qZhOkHYnjKyNMHTSllNpleBC3NP/lI5cJ0jD+0M+mPysBGadhHMdNPb/kSRqKn82 xoVxLxbNGudPo/wWtJFAA24xQctyZszZTEfjxvYspSzkdEcW2yERFS+BfUwDviAJNqexo6CS3ZepU O4BMy6lZvVpzaOpOkPdu3cEpRaVYG7hyeF+mdS6vuUXQ5WAqNkNv5YceFjjOLHhOX2p76OD2dZ/Mr bMP+2xkX7K0rN3BhkJ6Q7Q==; In-Reply-To: <8734s7c6cv.fsf@breatheoutbreathe.in> (message from Joseph Turner on Sat, 30 Mar 2024 22:32:26 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282414 Archived-At: > From: Joseph Turner > Cc: 70093@debbugs.gnu.org, da_vid@orange.fr > Date: Sat, 30 Mar 2024 22:32:26 -0700 > > Eli Zaretskii writes: > > >> Cc: Eli Zaretskii , David Ponce > >> From: Joseph Turner > >> Date: Sat, 30 Mar 2024 12:44:14 -0700 > >> > >> With the resolution of bug#69992, it may be possible to remove the > >> `image-tests--map-equal' equality predicate from lisp/image-tests.el. > > > > Why is it a good idea to remove tests? If the test tests some of our > > code which should work as the test assumes, we should not remove it. > > Not removing tests, but rather making the tests more strict (if possible). > > >> Eli and David, would you please apply the attached patch and then run > >> the tests to see if we still need to allow for tolerances in > >> `image--compute-map-and-original-map'? > > > > ENOPATCH > > Sorry about that. Please check if the tests still pass on your machine > when we use `equal' to compare image maps. They pass, thanks.