From: Eli Zaretskii <eliz@gnu.org>
To: Joseph Turner <joseph@breatheoutbreathe.in>
Cc: 70093@debbugs.gnu.org, da_vid@orange.fr
Subject: bug#70093: Remove unnecessary `image-tests--map-equal'
Date: Sun, 31 Mar 2024 10:33:53 +0300 [thread overview]
Message-ID: <86o7auc0ta.fsf@gnu.org> (raw)
In-Reply-To: <8734s7c6cv.fsf@breatheoutbreathe.in> (message from Joseph Turner on Sat, 30 Mar 2024 22:32:26 -0700)
> From: Joseph Turner <joseph@breatheoutbreathe.in>
> Cc: 70093@debbugs.gnu.org, da_vid@orange.fr
> Date: Sat, 30 Mar 2024 22:32:26 -0700
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> Cc: Eli Zaretskii <eliz@gnu.org>, David Ponce <da_vid@orange.fr>
> >> From: Joseph Turner <joseph@breatheoutbreathe.in>
> >> Date: Sat, 30 Mar 2024 12:44:14 -0700
> >>
> >> With the resolution of bug#69992, it may be possible to remove the
> >> `image-tests--map-equal' equality predicate from lisp/image-tests.el.
> >
> > Why is it a good idea to remove tests? If the test tests some of our
> > code which should work as the test assumes, we should not remove it.
>
> Not removing tests, but rather making the tests more strict (if possible).
>
> >> Eli and David, would you please apply the attached patch and then run
> >> the tests to see if we still need to allow for tolerances in
> >> `image--compute-map-and-original-map'?
> >
> > ENOPATCH
>
> Sorry about that. Please check if the tests still pass on your machine
> when we use `equal' to compare image maps.
They pass, thanks.
prev parent reply other threads:[~2024-03-31 7:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 19:44 bug#70093: Remove unnecessary `image-tests--map-equal' Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 22:04 ` bug#70093: *** SPAM *** " David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-31 7:37 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-31 10:08 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-02 10:36 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-06 1:50 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-07 16:01 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-31 5:10 ` Eli Zaretskii
2024-03-31 5:32 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-31 7:33 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o7auc0ta.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70093@debbugs.gnu.org \
--cc=da_vid@orange.fr \
--cc=joseph@breatheoutbreathe.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.