From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70301: 30.0.50; secrets-create-item mangles cyrillic passwords Date: Wed, 10 Apr 2024 18:44:35 +0300 Message-ID: <86o7ahusrg.fsf@gnu.org> References: <1712650236526.1662743497.3911072838@cdots.bg> <86o7aix3wq.fsf@gnu.org> <87jzl5s06c.fsf@gmx.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28279"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70301@debbugs.gnu.org, k.ninev@cdots.bg To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 10 17:45:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rua8I-0007A3-IH for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Apr 2024 17:45:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rua87-0002V7-Pi; Wed, 10 Apr 2024 11:44:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rua86-0002Sr-Ax for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2024 11:44:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rua86-00074R-1Y for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2024 11:44:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rua8E-00038a-FT for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2024 11:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Apr 2024 15:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70301 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70301-submit@debbugs.gnu.org id=B70301.171276389911982 (code B ref 70301); Wed, 10 Apr 2024 15:45:02 +0000 Original-Received: (at 70301) by debbugs.gnu.org; 10 Apr 2024 15:44:59 +0000 Original-Received: from localhost ([127.0.0.1]:54201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rua88-00036n-Ms for submit@debbugs.gnu.org; Wed, 10 Apr 2024 11:44:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rua85-00035N-3W for 70301@debbugs.gnu.org; Wed, 10 Apr 2024 11:44:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rua7q-000730-4k; Wed, 10 Apr 2024 11:44:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xhlATQzFrZ5VDC/0gf43MMOs1G47B3nvoq7mzMDCdRg=; b=HSmMNjj0aiYs WRp8Hy+9SSqFiFI/jpBeKgTHlqO3UUIoNLcM34ANHJxEA55qiZUp6LhH7EPwTUyv9guOr97vEmy4V oguUtOaIuz8A/C8F0I0Uye1EtAVQoyI8/9VuNphh/iuNL/JOQSvtGmKKJ+o1WxQUIpAuAS8KJRxZb mQISaVLRK6XeMTqXBAtdi0/rEUW/AgwGH1bI42Ku1MU8jUm8r0YJRZnYVnnSRKr0wH7T6l80Rop2b 2MFM8tzOh98+GGOMQaWe85OGlXqGFik8W+n27RGEAEz9EfOGfGncyZha0Rc954of6UnSTdzQoD00m euZ0UOuupsyLYqoRr3RBFw==; In-Reply-To: <87jzl5s06c.fsf@gmx.de> (message from Michael Albinus on Wed, 10 Apr 2024 17:32:43 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283054 Archived-At: > From: Michael Albinus > Cc: k.ninev@cdots.bg, 70301@debbugs.gnu.org > Date: Wed, 10 Apr 2024 17:32:43 +0200 > > > Does the patch below give good results? > > Thanks for the patch. However, I believe we shouldn't fix it in > secrets.el, but in dbus.el. Then we ought to update the doc string of dbus-string-to-byte-array, which currently says the argument should be a UTF-8 encoded string. > > Michael, I think we have a similar problem in > > dbus-byte-array-to-string: when MULTIBYTE is non-nil, the function > > should call decode-coding-string on the unibyte string it produces > > instead of converting each byte to multibyte. Because the bytes in > > the argument BYTE-ARRAY are not characters, they are raw bytes of the > > UTF-8 sequence, so calling 'string' on them is not TRT. > > Yes. The following patch works for me. WDYT? If you are okay with changing the behavior of dbus-byte-array-to-string in backward-incompatible ways, I don't mind. But maybe this should be called out in NEWS.