all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 70301@debbugs.gnu.org, k.ninev@cdots.bg
Subject: bug#70301: 30.0.50; secrets-create-item mangles cyrillic passwords
Date: Wed, 10 Apr 2024 18:44:35 +0300	[thread overview]
Message-ID: <86o7ahusrg.fsf@gnu.org> (raw)
In-Reply-To: <87jzl5s06c.fsf@gmx.de> (message from Michael Albinus on Wed, 10 Apr 2024 17:32:43 +0200)

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: k.ninev@cdots.bg,  70301@debbugs.gnu.org
> Date: Wed, 10 Apr 2024 17:32:43 +0200
> 
> > Does the patch below give good results?
> 
> Thanks for the patch. However, I believe we shouldn't fix it in
> secrets.el, but in dbus.el.

Then we ought to update the doc string of dbus-string-to-byte-array,
which currently says the argument should be a UTF-8 encoded string.

> > Michael, I think we have a similar problem in
> > dbus-byte-array-to-string: when MULTIBYTE is non-nil, the function
> > should call decode-coding-string on the unibyte string it produces
> > instead of converting each byte to multibyte.  Because the bytes in
> > the argument BYTE-ARRAY are not characters, they are raw bytes of the
> > UTF-8 sequence, so calling 'string' on them is not TRT.
> 
> Yes. The following patch works for me. WDYT?

If you are okay with changing the behavior of
dbus-byte-array-to-string in backward-incompatible ways, I don't mind.
But maybe this should be called out in NEWS.





  reply	other threads:[~2024-04-10 15:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-09  8:18 bug#70301: 30.0.50; secrets-create-item mangles cyrillic passwords k.ninev--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09  9:48 ` Eli Zaretskii
2024-04-09 10:09   ` k.ninev
2024-04-09 10:23     ` Eli Zaretskii
2024-04-10 15:32   ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-10 15:44     ` Eli Zaretskii [this message]
2024-04-10 16:10       ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-12  8:14         ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-12  8:51           ` k.ninev
2024-04-12  8:59             ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-12 11:37               ` Eli Zaretskii
2024-04-12 13:53                 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86o7ahusrg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=70301@debbugs.gnu.org \
    --cc=k.ninev@cdots.bg \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.