From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v6] Add support for colored and styled underlines on tty frames Date: Sun, 21 Apr 2024 18:57:53 +0300 Message-ID: <86o7a27loe.fsf@gnu.org> References: <20240414135632.432193-1-mohkale@kisara.moe> <868r18a1oz.fsf@gnu.org> <87y196ixaz.fsf@kisara.moe> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14352"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62994@debbugs.gnu.org To: Mohsin Kaleem Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 21 17:59:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ryZaw-0003TI-0L for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Apr 2024 17:59:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ryZaa-0002Om-Qz; Sun, 21 Apr 2024 11:58:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryZaZ-0002OS-3Z for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2024 11:58:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ryZaY-0002Ee-Rh for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2024 11:58:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ryZao-0005my-0A for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2024 11:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Apr 2024 15:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.171371510521972 (code B ref 62994); Sun, 21 Apr 2024 15:59:01 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 21 Apr 2024 15:58:25 +0000 Original-Received: from localhost ([127.0.0.1]:43574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryZaA-0005hu-82 for submit@debbugs.gnu.org; Sun, 21 Apr 2024 11:58:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryZa5-0005gb-6g for 62994@debbugs.gnu.org; Sun, 21 Apr 2024 11:58:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryZZj-00027n-VE; Sun, 21 Apr 2024 11:57:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6eA9KORFyVI1HTnW1NcJuVuEt0oDcCdulHxs0dW/SqY=; b=SBJHM7RMitmU o4y+66RNY86pLI3D74ZPGThA0ykCh2vc4CQlK4iIe8RkHQAnsPG8s17RgX7R+kYR61mUKb9v5QwKs BSxio0Rk1Nk0talk5/eoAmzG7e3MRpUA/20citCVB+M8jcRL3OQ56BQVHGS/AyDPVX2YIsWmwnhvZ K7g3M/f0HSE4BFqMkKP3BQ75uvuOLBlZkbRMGbYuorP6JVDeBaRYQyahMukzS8Ud1TDWypHHPPbw7 nh6eOsd7YGKCWGFYDgCpdF96Yyb6hcEF8fy/3j56XjUGoadp9WzeRLhGW0PB87b/DmzNKB2HC5TXv B0kwVlSvCLZKoQfM1NBRqw==; In-Reply-To: <87y196ixaz.fsf@kisara.moe> (message from Mohsin Kaleem on Sun, 21 Apr 2024 15:51:16 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283772 Archived-At: > From: Mohsin Kaleem > Cc: 62994@debbugs.gnu.org > Date: Sun, 21 Apr 2024 15:51:16 +0100 > > Eli Zaretskii writes: > > > The Subject line is longer than 78 characters, so our commit hooks > > didn't allow me to apply this. Please make the Subject line shorter, > > possibly by dropping the bug number (mention the bug number somewhere > > in the rest of the log message). > > Sorry, I'm not quite sure what you mean. Are you referring to the > subject line of the email message? That's 85 characters, but removing re > and the [PATCH X] part condenses it to 70 characters. I don't know what exactly does "git am" do with Subject, but the fact is the pre-commit hook aborted the commit. How about if you produce a patch with "git format-patch", and then attach the result to the mail (as an attachment)? It could be that the problem here is with some problematic format of the Subject line, but there's no reason to have the patch heading be the Subject of the email. > To confirm this is what I did, I'm not sure if it's exactly what you > were recommending: > > 1. emacs -Q .git/COMMIT_EDITMSG > 2. M-x change-log-mode > 3. C-SPC to end of buffer message > 4. C-M-\ > 5. Manually remove the leading indentation Emacs seems to have inserted > (other commit messages didn't seem to have this). > > The end result doesn't seem to have changed the line length of anything, > although it did highlight one point where the entry was malformed. That's not what I meant. In order to have the proper line length, you need first to add a TAB before each line, then turn on change-log-mode, then fill the lines with M-q, then remove the leading TABs. The reason for this is that the Git logs are used to produce ChangeLog files when we prepare a release, and ChangeLog files have a TAB before each line of the log entries. > Updated. > > >> - return false; /* same as default */ > >> + return false; /* same as default */ > > > > Why this whitespace change? > > I suspect this was a byproduct of me re-indenting comments in an earlier patch. > > Removed now. Did you forget to attach the updated patch?