From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: face-cache Date: Sun, 28 Apr 2024 13:17:19 +0300 Message-ID: <86o79tu6z4.fsf@gnu.org> References: <87r0eqaslt.fsf@gmail.com> <87mspeas8s.fsf@gmail.com> <87bk5tc1j6.fsf@gmail.com> <877cghc0yy.fsf@gmail.com> <8734r5bzxt.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2962"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 28 12:17:59 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s11bb-0000dC-44 for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Apr 2024 12:17:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s11b9-0002Gl-Uz; Sun, 28 Apr 2024 06:17:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s11b7-0002GG-Pt for emacs-devel@gnu.org; Sun, 28 Apr 2024 06:17:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s11b6-0008Md-U0; Sun, 28 Apr 2024 06:17:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JEJa24+dmcLjG4EZ7+rJ/cakLjuDHNTud/EQzg9ynJQ=; b=ZeoOELJWDWDn K6X8yxnscIgFwdecvwzHVDjPVRQTJJasydx7i/uFTnQgABmEdpoDuytR969sZk0dbI+Kj7wZAOeNB DmGgnIGp+iZpODZ1cF0TUAEX7Wz0nQahT4UAoQXg8Si6YjhT0UHQxquTYtA7xZIXQSg7CtRDcmMMN LZu4emfSOYUXoFc+45SnC0cVuEgJ+n+ovx+FHHHGYQKBBLXGo/umcXhJno+7AqE80BDa1Y3OW6qjP tWaNRG+mD4Mjos1tVNyJs4gQ7FLpuzuZrzzwKPnkEF6adBwGLqzF2NLeHjHQTfRroVLYe5kl8+we8 tOJkTxIVxRKlEmkBhgaLJg==; In-Reply-To: <8734r5bzxt.fsf@gmail.com> (message from Helmut Eller on Sun, 28 Apr 2024 11:26:38 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318274 Archived-At: > From: Helmut Eller > Cc: Eli Zaretskii , emacs-devel missing value > > Date: Sun, 28 Apr 2024 11:26:38 +0200 > > --- a/src/igc.c > +++ b/src/igc.c > @@ -1332,14 +1332,8 @@ fix_frame (mps_ss_t ss, struct frame *f) > if (*font_ptr) > IGC_FIX12_RAW (ss, font_ptr); > > -# ifdef HAVE_NS > - font_ptr = &f->output_data.ns->font; > - if (*font_ptr) > - IGC_FIX12_RAW (ss, font_ptr); > - > - struct ns_display_info *d = f->output_data.ns->display_info; > - IGC_FIX12_OBJ (ss, &d->name_list_element); > -# endif > + Lisp_Object *nle = &FRAME_DISPLAY_INFO(f)->name_list_element; > + IGC_FIX12_OBJ (ss, nle); In the w32 build, name_list_element is staticpro'd (because there's only one FRAME_DISPLAY_INFO, and it's in a global variable), so I guess the above is not needed on MS-Windows?