Re: MPS: Problem with dynamic modules

[Eli Zaretskii <eliz@gnu.org>]

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: dancol@dancol.org,  eller.helmut@gmail.com,  emacs-devel@gnu.org
> Date: Mon, 20 May 2024 07:35:33 +0200
> 
> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
> 
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> >>> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> >>> Cc: Daniel Colascione <dancol@dancol.org>,  eller.helmut@gmail.com,
> >>>   emacs-devel@gnu.org
> >>> Date: Sun, 19 May 2024 18:17:06 +0200
> >>> 
> >>> Eli Zaretskii <eliz@gnu.org> writes:
> >>> 
> >>> > No, I mean tell the pool we are using now that this vector cannot be
> >>> > moved.  AFAIU, this should be possible, and we do that in other cases,
> >>> > no?
> >>> 
> >>> Sort of. The only way to do this is to add a reference to the object to an
> >>> ambiguous root. I.e. we need some registry data structure for such
> >>> objects and make that an ambig root.
> >>
> >> That sounds like the easiest solution, no?
> >
> > Hm, I wouldn't say so. The easiest for me would be to malloc the value,
> > followed by using the AMS pool, followed by implementing a tree or
> > whatever is good for that purpose, making it a root and scan it.
> 
> I've added said pool now.

I tried to run the emacs-module test, but it doesn't compile here:

    CCLD     src/emacs-module-resources/mod-test.dll
  make[1]: Entering directory `/d/gnu/git/emacs/feature/test'
  In file included from src/emacs-module-resources/mod-test.c:47:
  ../src/emacs-module.h:1120:26: error: unknown type name 'Lisp_Object'
   1120 | struct emacs_value_tag { Lisp_Object v; };
	|                          ^~~~~~~~~~~
  ../src/emacs-module.h:1128:27: error: field 'header' has incomplete type
   1128 |   union vectorlike_header header;
	|                           ^~~~~~

Does it compile for you?  Why did you move the emacs_value_tag stuff
from emacs-module.c (which is compiled as part of Emacs) to
emacs-module.h (which is included by modules, which aren't supposed to
know about Lisp_Object, they are supposed to use emacs_value instead.
But not a module cannot be compiled without including lisp.h, which I
think is wrong.