From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: profiler Date: Fri, 21 Jun 2024 13:45:59 +0300 Message-ID: <86o77ulgk8.fsf@gnu.org> References: <87v823xvq1.fsf@localhost> <86cyobmmhc.fsf@gnu.org> <87r0crxung.fsf@localhost> <87le2zxsqx.fsf@localhost> <8634p6n7jd.fsf@gnu.org> <87tthm3gq2.fsf@gmail.com> <87sex6ags5.fsf@localhost> <87msne3flr.fsf@gmail.com> <87frt63dvt.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22259"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eller.helmut@gmail.com, yantar92@posteo.net, emacs-devel@gnu.org To: Gerd =?utf-8?Q?M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 21 12:46:21 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKbme-0005UO-Kr for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Jun 2024 12:46:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKbmQ-0006wF-9g; Fri, 21 Jun 2024 06:46:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKbmN-0006v4-Bi for emacs-devel@gnu.org; Fri, 21 Jun 2024 06:46:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKbmN-0004Y4-04; Fri, 21 Jun 2024 06:46:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=S8Ks+B3c/+jDMJ/To35rM9LfNtikana6ocHxTuxAN1Q=; b=o9XdjvCu/soClZ491fjZ VqOQH6XlQ7kaim0p5dqD9e3Ppo6I/moS4cTD79sPBMCUX6Lo9YJdX5F6sBPbcBq4YnIW2caCureDA GRgLwxzjNxxma3Gn9xizF2wc80Ws9f19LkeP/Fki2SythfGZmEhSpVMGTw85rne70WLmJeoiGyqof vxj/5qPLko0XjoS3bJ2OvGtUtj1jLE/K6OVvP6SNE0jv3TxWtH9QrDilyr2yi6W3Y/VDplS+O2wdR jar7AO8r1kXB77r0K73WLRJ0xDrwvteOzvZBo5TkFvyzOFPcWoeJwoViGH7gRsWlXK4fKyAz2gKUM MOH2i18PKtB8MA==; In-Reply-To: (message from Gerd =?utf-8?Q?M=C3=B6llmann?= on Fri, 21 Jun 2024 10:31:55 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320382 Archived-At: > From: Gerd Möllmann > Cc: Ihor Radchenko , Eli Zaretskii , > emacs-devel@gnu.org > Date: Fri, 21 Jun 2024 10:31:55 +0200 > > Helmut Eller writes: > > > On Fri, Jun 21 2024, Gerd Möllmann wrote: > > > >>> There is a function mps_arena_busy, that might be useful. The doc says > >>> that it should only be used for debugging. But the implementation > >>> actually checks if the arena holds a lock. > >> > >> Yes, the SIBPROF handler could at least return early then. > > > > Perhaps something like this? > > Not sure. The result of is_busy is only valid at the point in time when > it is called. Are you thinking about what happens when GC is run concurrently? Because this is not what happens here, AFAIU. Let's focus on fixing the actual issue we see in the backtrace, and consider its possible generalizations later. Are you saying that is_busy could return false in the situation we see in the backtrace, i.e. during the entire time MPS processes its protection-induced SIGSEGV?