From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 5f9b5803bea: Fix zooming images in SHR Date: Sun, 23 Jun 2024 22:23:44 +0300 Message-ID: <86o77rcvjz.fsf@gnu.org> References: <171912324641.7384.11296304660836747605@vcs2.savannah.gnu.org> <20240623061407.0C6DDC1FB5C@vcs2.savannah.gnu.org> <5f6b8e84-cd41-4229-ab22-64c931ff7966@app.fastmail.com> <50938116-7ba6-5625-94e0-fb55dfdc449d@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36939"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jm@pub.pink, emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 23 21:24:31 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLSpD-0009P1-Bz for ged-emacs-devel@m.gmane-mx.org; Sun, 23 Jun 2024 21:24:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLSoY-0001At-0Y; Sun, 23 Jun 2024 15:23:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLSoW-0001AV-6P for emacs-devel@gnu.org; Sun, 23 Jun 2024 15:23:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLSoV-0004ib-9k; Sun, 23 Jun 2024 15:23:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+HaoJ26EEMf6rDZSorVL7oPlPgAonL7RVyzLcAKo1g8=; b=HxjTaF1MCapI 5QOedaVE/WmUOTNjVy9j5DYjXA/aIGJl6EcuJBkeJyzw3mnc/nkkjjsB+V3qDp22++2aEDL1VIZeu nV+1UadeEtuaI4WFKi2URP0ojgIHfWx/NPRQlNmTABZEnN0FRX9YLmMbKDVz2Bi8lxJ3SxW5gdvkS yG9xQj1vPVmnhsiLwJuU+S6VeqIz4SEjhI04db2NtKgN6gogGQV1Z5F1+eWUsRmWGh0gAsh6MzxZf kSamdRbtfPNwIEVvTRwmZoE88kyGVqnYdWNki3vc/N3nTF+tBZpowAp54Hu3YpYnn3umNfPZawnQm zElv6wiscslF3pb6z32WNQ==; In-Reply-To: <50938116-7ba6-5625-94e0-fb55dfdc449d@gmail.com> (message from Jim Porter on Sun, 23 Jun 2024 11:42:53 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320562 Archived-At: > Date: Sun, 23 Jun 2024 11:42:53 -0700 > From: Jim Porter > > On 6/23/2024 7:36 AM, john muhl wrote: > > The zoom-image test added here fails on --without-x builds. > > Thanks for noticing this. Fixed on the release branch with 6619aec6bca. Thanks, but the test fails for me on MS-Windows: Test shr-test/zoom-image condition: Info: image with alt=nil (error "timed out waiting for condition") FAILED 3/4 shr-test/zoom-image (5.053704 sec) at lisp/net/shr-tests.el:136 (The other test failed as well, but I fixed it.) Frankly, I have no idea why it fails, because I only vaguely understand the idea of the test. Feel free to ask questions or suggests what to test.