From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71734: 30.0.50; eww interprets make errors as URLs Date: Thu, 27 Jun 2024 12:00:33 +0300 Message-ID: <86o77m69qm.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2361"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 71734@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 27 11:01:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMl0E-0000Mq-EY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jun 2024 11:01:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMl03-0002sy-Qk; Thu, 27 Jun 2024 05:01:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMkzz-0002sZ-Pd for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 05:00:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMkzz-0001kM-Hd for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 05:00:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMl02-0008Di-1K for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 05:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2024 09:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71734 X-GNU-PR-Package: emacs Original-Received: via spool by 71734-submit@debbugs.gnu.org id=B71734.171947884931567 (code B ref 71734); Thu, 27 Jun 2024 09:01:01 +0000 Original-Received: (at 71734) by debbugs.gnu.org; 27 Jun 2024 09:00:49 +0000 Original-Received: from localhost ([127.0.0.1]:40973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMkzp-0008D5-FW for submit@debbugs.gnu.org; Thu, 27 Jun 2024 05:00:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMkzn-0008Ct-Is for 71734@debbugs.gnu.org; Thu, 27 Jun 2024 05:00:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMkze-0001iB-RG; Thu, 27 Jun 2024 05:00:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=B5gouYg6fQC0TUT/Q4NqunGe72qRfFoOwnVbsFBPAHw=; b=XT9hV+3HYhBb vqqFWrwRzQbx1AsU1rBzRYBGWH/ozN4Ud0VtlBkkFb+7g06jhYp3eYFAXeXWLEwpmrusGQKf5Y9nI AgMuRoCkeKLIJWZzmbC/pZClPgq54d9FbeQQNFceI0aCfdO6f7O8p60j03zgM4welTenZzbUAWtve r/tf7/rJaL3odFCYkqT1kgIma3n7HRgGFpdopqv1D4V+11MiiFCA//7At1Mj2YfNnSVifEs+wYwTP 3e/eyuJ5rNQWyQIAaoqjyI4BvOaxT6iK0JsE15HFbd6tOEbMX5TdHZqbvw4EOBLT5qDGb00r/9OPc 8QQg815q4lTtySMtQYQKCg==; In-Reply-To: (message from Stefan Kangas on Sun, 23 Jun 2024 06:11:57 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288000 Archived-At: > Cc: Lars Ingebrigtsen > From: Stefan Kangas > Date: Sun, 23 Jun 2024 06:11:57 -0700 > > `M-x eww` currently interprets this as a URL: > > make: *** [Makefile:240: __sub-make] Error 2 > > I think this is due to the below commit: > > ``` > commit 4113ac253456027c4b54b92a617e0c2b3003a049 > Author: Lars Ingebrigtsen > Date: Sun Jan 11 15:58:10 2015 +0100 > > Further eww URL DWIM tweaks > > * net/eww.el (eww): Interpret anything that looks like a protocol > designator as a full URL. > > diff --git a/lisp/net/eww.el b/lisp/net/eww.el > --- a/lisp/net/eww.el > +++ b/lisp/net/eww.el > @@ -258,29 +258,31 @@ > - (if (or (string-match "\\`https?:" url) > + ;; Anything that starts with something that vaguely looks > + ;; like a protocol designator is interpreted as a full URL. > + (if (or (string-match "\\`[A-Za-z]+:" url) > ``` > > I think that this is much too dwim-y, and we should go back to the old > code. OTOH, expecting "M-x eww" to do something sensible in the above case is a bit far-fetched, IMHO. I think the question we should ask ourselves is whether the use cases fixed by Lars's change are more important to keep supported than fixing the case above.