From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: larsi@gnus.org, 71734@debbugs.gnu.org
Subject: bug#71734: 30.0.50; eww interprets make errors as URLs
Date: Thu, 27 Jun 2024 12:00:33 +0300 [thread overview]
Message-ID: <86o77m69qm.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkm=JHA9wuX5Cc1n1VLbWik_QoU8+7h_dw-6+yB1Br0hw-Q@mail.gmail.com> (message from Stefan Kangas on Sun, 23 Jun 2024 06:11:57 -0700)
> Cc: Lars Ingebrigtsen <larsi@gnus.org>
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sun, 23 Jun 2024 06:11:57 -0700
>
> `M-x eww` currently interprets this as a URL:
>
> make: *** [Makefile:240: __sub-make] Error 2
>
> I think this is due to the below commit:
>
> ```
> commit 4113ac253456027c4b54b92a617e0c2b3003a049
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sun Jan 11 15:58:10 2015 +0100
>
> Further eww URL DWIM tweaks
>
> * net/eww.el (eww): Interpret anything that looks like a protocol
> designator as a full URL.
>
> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> --- a/lisp/net/eww.el
> +++ b/lisp/net/eww.el
> @@ -258,29 +258,31 @@
> - (if (or (string-match "\\`https?:" url)
> + ;; Anything that starts with something that vaguely looks
> + ;; like a protocol designator is interpreted as a full URL.
> + (if (or (string-match "\\`[A-Za-z]+:" url)
> ```
>
> I think that this is much too dwim-y, and we should go back to the old
> code.
OTOH, expecting "M-x eww" to do something sensible in the above case
is a bit far-fetched, IMHO.
I think the question we should ask ourselves is whether the use cases
fixed by Lars's change are more important to keep supported than
fixing the case above.
next prev parent reply other threads:[~2024-06-27 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 13:11 bug#71734: 30.0.50; eww interprets make errors as URLs Stefan Kangas
2024-06-27 9:00 ` Eli Zaretskii [this message]
2024-06-28 4:09 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o77m69qm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71734@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.