From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input Date: Thu, 04 Jul 2024 17:12:43 +0300 Message-ID: <86o77d8cv8.fsf@gnu.org> References: <86ikxltzhx.fsf@mail.linkov.net> <861q49a8vt.fsf@gnu.org> <86y16h8olf.fsf@gnu.org> <878qyh79ov.fsf@gmx.net> <86v81l8gnj.fsf@gnu.org> <874j95706i.fsf@gmx.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35133"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jpw@gnu.org, juri@linkov.net, me@eshelyaron.com, basil@contovou.net, 71927@debbugs.gnu.org, kickingvegas@gmail.com To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 04 16:14:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPNE3-0008sa-Ok for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jul 2024 16:14:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPNDm-0004XA-No; Thu, 04 Jul 2024 10:14:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPNDk-0004Wu-Kz for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 10:14:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPNDk-00059S-BB for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 10:14:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPNDm-0002dL-D9 for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 10:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2024 14:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71927 X-GNU-PR-Package: emacs Original-Received: via spool by 71927-submit@debbugs.gnu.org id=B71927.172010239310059 (code B ref 71927); Thu, 04 Jul 2024 14:14:02 +0000 Original-Received: (at 71927) by debbugs.gnu.org; 4 Jul 2024 14:13:13 +0000 Original-Received: from localhost ([127.0.0.1]:42660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPNCy-0002cA-DI for submit@debbugs.gnu.org; Thu, 04 Jul 2024 10:13:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPNCw-0002bx-6T for 71927@debbugs.gnu.org; Thu, 04 Jul 2024 10:13:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPNCl-00050Z-LG; Thu, 04 Jul 2024 10:12:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SLG8yI3c9w87x/wvqaMQAkiuBoEjj7SMIJxX5SkomtM=; b=Lksq2sXj/6QO /ZJZLHn5RMjkfHQajuTO7CkLG54b378yfj1JFJcZry0raZfmdQG18sU2xyANndcWctmKYTMmLd3Ab h3enKFoszOnU/wB7qyxAtAGROVcxTCMxo2o1zn+mCG9e8bmpWGNk6jVgan/cxw8p4ll3NLZEjKGSH cMPYggM9dnqqEyMiPw0WxrpKF/RtzdatlUGah3BW5uay1TLXzqErXAW6TT2zB0CvBSxtdLRB/LWo5 jzSj3Me1Z6UY6ED38EClex9DDqxlKVXnx+DIFGVuch2oyWOFqI2kNFyIG4AKBW31W2mhdK4j4lqrR P/wlCHELP7Kz3HKgKgmTcQ==; In-Reply-To: <874j95706i.fsf@gmx.net> (message from Stephen Berman on Thu, 04 Jul 2024 15:32:05 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288372 Archived-At: > From: Stephen Berman > Cc: me@eshelyaron.com, kickingvegas@gmail.com, 71927@debbugs.gnu.org, > basil@contovou.net, jpw@gnu.org, juri@linkov.net > Date: Thu, 04 Jul 2024 15:32:05 +0200 > > On Thu, 04 Jul 2024 15:50:56 +0300 Eli Zaretskii wrote: > > >> From: Stephen Berman > >> Cc: Eshel Yaron , kickingvegas@gmail.com, > >> 71927@debbugs.gnu.org, basil@contovou.net, jpw@gnu.org, > >> juri@linkov.net > >> Date: Thu, 04 Jul 2024 12:06:40 +0200 > >> > >> >> FWIW, AFAICT everything is working correctly, it's just that the > >> >> "Operation finished" message hides the prompt. ibuffer-do-isearch > >> >> should tell define-ibuffer-op not to display that message, somehow. > >> > > >> > I don't see how this could be considered "correct": the "Operation > >> > finished" message is supposed to be shown only after the Isearch is > >> > finished in all the marked buffer, not before. It looks like we need > >> > a function that will not return until all the buffers where searched, > >> > because that's what define-ibuffer-op expects. Don't you agree? > >> > >> The attached patch appears to DTRT, but I only tested it briefly. > > > > Thanks, but does it really make sense to change define-ibuffer-op to > > fix the functions which (evidently) use it incorrectly? I think the > > fix needs to be in the same place where the bug is. > > That's what I thought, too, but I don't see a way to do that, because > define-ibuffer-op hard-codes displaying a message at the end of the > body. But in this case that message seems superfluous, in addition to > hiding the isearch prompt, because when isearch goes through the marked > buffers, it then displays its own message that the operation is > complete. So this looks like a case when define-ibuffer-op is currently > too rigid. Then maybe these two commands should be defined using defun, not define-ibuffer-op? There's nothing forcing us to define each ibuffer command via define-ibuffer-op, is it? > However, I acknowledge that I don't really grok the interaction with > isearch, i.e., why the "Operation finished" message is shown > although isearch hasn't even begun. Juri will know for sure, but AFAIU all the commands that invoke Isearch just enter a special mode (including the conditions/commands to exit Isearch). IOW, when isearch-forward returns, the search did not yet begin; instead, Emacs is in a special mode where typing characters adds them to search string and triggers another round of search.