From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#71905: 29.2.50; recover-session fails to disable dired-omit-mode if the latter is set globally Date: Sun, 07 Jul 2024 09:52:27 +0300 Organization: LINKOV.NET Message-ID: <86o779ithw.fsf@mail.linkov.net> References: <868qyj7iq0.fsf@mail.linkov.net> <86tth5vexy.fsf@mail.linkov.net> <86sewm4yx2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1127"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: app-emacs-dev@janestreet.com, azeng@janestreet.com, 71905@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 07 09:02:36 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQLus-00009I-VA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Jul 2024 09:02:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQLub-0001RI-8a; Sun, 07 Jul 2024 03:02:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQLuJ-00016t-R3 for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 03:02:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQLuH-0000Nj-MR for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 03:01:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sQLuL-0005j5-J6 for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 03:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Jul 2024 07:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71905 X-GNU-PR-Package: emacs Original-Received: via spool by 71905-submit@debbugs.gnu.org id=B71905.172033568021931 (code B ref 71905); Sun, 07 Jul 2024 07:02:01 +0000 Original-Received: (at 71905) by debbugs.gnu.org; 7 Jul 2024 07:01:20 +0000 Original-Received: from localhost ([127.0.0.1]:47189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQLtf-0005hc-I6 for submit@debbugs.gnu.org; Sun, 07 Jul 2024 03:01:19 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:46929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQLtd-0005hM-9x; Sun, 07 Jul 2024 03:01:17 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 1EE37E0003; Sun, 7 Jul 2024 07:01:03 +0000 (UTC) In-Reply-To: <86sewm4yx2.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Jul 2024 13:06:49 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288545 Archived-At: close 71905 30.0.60 thanks >> >> When dired-omit-mode is set non-nil globally, recover-session fails to >> >> show any auto-save files because they continue to be omitted. >> > >> > Indeed, handling of dired-omit-mode in recover-session is wrong. >> > For example, I'm using a lambda and it fails. Therefore needed >> > to rely on such patch: >> >> Eli, please decide this should be fixed in master or emacs-30? > > Please install on emacs-30, and thanks. Now installed on emacs-30. The patch uses + (when (bound-and-true-p dired-omit-mode) + (dired-omit-mode -1))) that is the same as in 'dired-jump', but with one difference that 'dired-jump' uses (dired-omit-mode) that never disabled 'dired-omit-mode', so I fixed the bug in 'dired-omit-mode' as well to use -1.