all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: app-emacs-dev@janestreet.com, azeng@janestreet.com,
	71905@debbugs.gnu.org
Subject: bug#71905: 29.2.50; recover-session fails to disable dired-omit-mode if the latter is set globally
Date: Sun, 07 Jul 2024 09:52:27 +0300	[thread overview]
Message-ID: <86o779ithw.fsf@mail.linkov.net> (raw)
In-Reply-To: <86sewm4yx2.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Jul 2024 13:06:49 +0300")

close 71905 30.0.60
thanks

>> >> When dired-omit-mode is set non-nil globally, recover-session fails to
>> >> show any auto-save files because they continue to be omitted.
>> >
>> > Indeed, handling of dired-omit-mode in recover-session is wrong.
>> > For example, I'm using a lambda and it fails.  Therefore needed
>> > to rely on such patch:
>>
>> Eli, please decide this should be fixed in master or emacs-30?
>
> Please install on emacs-30, and thanks.

Now installed on emacs-30.  The patch uses

  +    (when (bound-and-true-p dired-omit-mode)
  +      (dired-omit-mode -1)))

that is the same as in 'dired-jump', but with one difference that
'dired-jump' uses (dired-omit-mode) that never disabled 'dired-omit-mode',
so I fixed the bug in 'dired-omit-mode' as well to use -1.





      reply	other threads:[~2024-07-07  6:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 17:07 bug#71905: 29.2.50; recover-session fails to disable dired-omit-mode if the latter is set globally Aaron Zeng
2024-07-02 18:27 ` Juri Linkov
2024-07-04  6:49   ` Juri Linkov
2024-07-04  7:43     ` Eli Zaretskii
2024-07-06 10:06     ` Eli Zaretskii
2024-07-07  6:52       ` Juri Linkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86o779ithw.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=71905@debbugs.gnu.org \
    --cc=app-emacs-dev@janestreet.com \
    --cc=azeng@janestreet.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.