From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#71883: [PATCH] Fix tab-bar-auto-width with customized tab-bar-tab-face-function Date: Mon, 19 Aug 2024 19:57:13 +0300 Organization: LINKOV.NET Message-ID: <86o75o30ye.fsf@mail.linkov.net> References: <87le2kaloz.fsf@breatheoutbreathe.in> <861q4ce1yb.fsf@mail.linkov.net> <877ce3damx.fsf@breatheoutbreathe.in> <86r0cb7l58.fsf@mail.linkov.net> <5aff3095-087f-493d-9251-8048b51280f9@alphapapa.net> <86msmzc7ne.fsf@mail.linkov.net> <86o77dox54.fsf@mail.linkov.net> <87a5ihgii9.fsf@breatheoutbreathe.in> <86jzhkgtb7.fsf@gnu.org> <865xt1lw66.fsf@mail.linkov.net> <87ikwttk96.fsf@breatheoutbreathe.in> <861q3h47ci.fsf@gnu.org> <87a5i5dqmd.fsf@breatheoutbreathe.in> <86plqmqgpa.fsf@mail.linkov.net> <87ed6xanny.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40746"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: adam@alphapapa.net, 71883@debbugs.gnu.org, Eli Zaretskii , shipmints@gmail.com To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 19 19:01:08 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sg5ki-000AMr-03 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Aug 2024 19:01:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sg5kO-0008FY-1o; Mon, 19 Aug 2024 13:00:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sg5jy-0008CX-EO for bug-gnu-emacs@gnu.org; Mon, 19 Aug 2024 13:00:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sg5jw-0005rY-I5 for bug-gnu-emacs@gnu.org; Mon, 19 Aug 2024 13:00:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=w6jGEZrz55OYSKYv4n7WHfOH2zjE6z3hlqqYGv/awzg=; b=jGfO90rbGuk3sF/TjMtM2YlHr9MYNYRXu5r/OGTHxpsitAxJ7F+iywu9sMTvZeTb5xsSP/45jh0IOdtElslWrNU1IZzoZEn2jhHzY3ljkPhCThF26tNuuA7FivUiLpqf3Alv18QiBdLOWsgc3W/9tS7GY/inao3Vl128olnIPch827z7u3yTACHL+LQSWulJtxgKEJer1P7znkrXHD9+fWF4zNKGpuu6WjU9+KwsJfg25OJN1Rf/yAGd2ccKXUph/Lt7jTFF9QW63bqtZilgZ/OVhRg/kh/3XbgJ2JhS9P9S5GksQv+J3AHNRq+PdSziSTbQMQoCmjDDTLgL+JLAJg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sg5kc-0002FL-CV for bug-gnu-emacs@gnu.org; Mon, 19 Aug 2024 13:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Aug 2024 17:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71883-submit@debbugs.gnu.org id=B71883.17240868158557 (code B ref 71883); Mon, 19 Aug 2024 17:01:02 +0000 Original-Received: (at 71883) by debbugs.gnu.org; 19 Aug 2024 17:00:15 +0000 Original-Received: from localhost ([127.0.0.1]:59111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sg5jq-0002Dv-Jx for submit@debbugs.gnu.org; Mon, 19 Aug 2024 13:00:14 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:34113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sg5jp-0002DP-2P; Mon, 19 Aug 2024 13:00:13 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id A535FE0007; Mon, 19 Aug 2024 16:59:03 +0000 (UTC) In-Reply-To: <87ed6xanny.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Fri, 09 Aug 2024 05:25:21 -0700") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290407 Archived-At: close 71883 31.0.50 thanks >>> +(defun tab-bar-auto-width-predicate-default (item) >>> + "Accepts tab ITEM and returns non-nil for tabs and tab groups." >>> + (string-match-p >>> + ;; (rx bos (or "current-tab" "current-group" "tab-" "group-")) >>> + "\\`\\(?:current-\\(?:group\\|tab\\)\\|\\(?:group\\|tab\\)-\\)" >>> + (symbol-name (nth 0 item)))) >> >> In this part please remove the current group from the default implementation, >> because it looks too ugly, and it was not resized before this change, since >> tab-bar-auto-width-faces didn't contain the tab-bar-tab-group-current face. > > If the simpler change offers feature parity, that sounds good to me. Thanks for the patch, I pushed it to master, then ameliorated it to keep backwards-compatibility for users customized these faces, but by default using your predicate on symbols.