From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73412: 31.0.50; Improve sql-read-product Date: Sat, 21 Sep 2024 18:21:03 +0300 Message-ID: <86o74h2fts.fsf@gnu.org> References: <874j69nklr.fsf@gmx.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26959"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73412@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 21 17:21:55 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ss1vm-0006rh-Qg for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Sep 2024 17:21:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ss1vb-0006gI-Rt; Sat, 21 Sep 2024 11:21:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ss1va-0006g8-Df for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 11:21:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ss1va-0004Sn-56 for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 11:21:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=eXIg6dwo7yg/70Oy9H+g8g7qvbGAjLqgDAwVfnsgxP0=; b=CdmRepOMGrjC69mlQsRDbY7AbFRzK4rWfduCC65YqCg5el++BCmT2fJStElrOzxQqXW23xRpJd5c4n2fGOXdyZdop8sw+hVvwo3sduGOwv5ja99tx+bzv0/WLd1IQiFbPAH3/2Pg7/H9kBPOdJ0PRdLyj01HYQnMnPMtzSX5yPNQFio1OEX4Q/ufLHg+iFqRp4qn76LutSAMeHSCF7gK8qWe57Hfrwt1uaIk2JIzDtaOA5cqQhhLLytBexs+W9NBLjmbDprmupMuvJGE4cbGSQX23JVw4gLTX5cxErosfwKfHINcvSXuyxFRMYOcTasXRc8/S2oN//1fZEYdvDsJsQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ss1vu-0006IN-7z for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 11:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Sep 2024 15:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73412 X-GNU-PR-Package: emacs Original-Received: via spool by 73412-submit@debbugs.gnu.org id=B73412.172693209424153 (code B ref 73412); Sat, 21 Sep 2024 15:22:02 +0000 Original-Received: (at 73412) by debbugs.gnu.org; 21 Sep 2024 15:21:34 +0000 Original-Received: from localhost ([127.0.0.1]:40208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ss1vR-0006HV-ST for submit@debbugs.gnu.org; Sat, 21 Sep 2024 11:21:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ss1vQ-0006HA-Hw for 73412@debbugs.gnu.org; Sat, 21 Sep 2024 11:21:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ss1v0-0004MR-EI; Sat, 21 Sep 2024 11:21:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eXIg6dwo7yg/70Oy9H+g8g7qvbGAjLqgDAwVfnsgxP0=; b=q6tU4jDuasPh 2mcO0+L7S9QgM90h06C9R1Q9xCXAa46jtSN9ObxD7K2PTHWcaqxlZbtuXxZkLHV09ybY2hlNPtWWx zP/brVH1YS6UOItD7otIe0VNbsa9ctzwcP/rM1kBpsfZRJ+0veNxqNgK417LdaFzD0JZjt95oEmq1 lF98428q4V94j6Xq5bOPrmS4akRdOZa2OcI2ed+i06UtZsAqkNyZPHfAMKrTW+9u30OJLDRR409Yp CBUg1FQmNtBSMpTgacF5akT4kCuV6mNdDYZwxk6/TiWgL/GZ8OPbanHswEKTz+WpyO7RmdIuRoYpM RxDYBY2I3HEgCMFPc+dlhA==; In-Reply-To: <874j69nklr.fsf@gmx.net> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292198 Archived-At: > Date: Sat, 21 Sep 2024 16:32:16 +0200 > From: Stephen Berman via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > 0. emacs -Q > 1. C-u M-x sql-product-interactive RET > > Now the minbuffer displays the following: > > SQL product: ansi > > so it you want to change the product, e.g. to postgres, you first have > to delete "ansi". > > Likewise, `M-x sql-set-product RET' produces the same minbuffer display, > requiring deletion to change the product. > > The reason "ansi" is displayed after the prompt is that the definition > of sql-read-product uses the same non-nil value of the deprecated > argument INITIAL-INPUT as is used for the argument DEF. The attached > patch makes INITIAL-INPUT nil, thus using only DEF, and also wraps the > prompt argument of sql-read-product in format-prompt, so the default > value is shown as part of the prompt and changing it does not require > deletion. The patch also adjusts the two callers of sql-read-product > accordingly. Thanks. I think this should go to the emacs-30 branch, no?