From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73604: [PATCH] Properly operate on current fileset revision in vc-hg-print-log Date: Thu, 03 Oct 2024 09:50:56 +0300 Message-ID: <86o741znlb.fsf@gnu.org> References: <87o7422any.fsf@melete.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11663"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 73604@debbugs.gnu.org To: Sean Whitton , Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 03 08:52:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1swFhO-0002sv-GS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Oct 2024 08:52:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swFgx-0006IM-Ry; Thu, 03 Oct 2024 02:52:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swFgw-0006Hz-4X for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2024 02:52:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1swFgv-00013V-Rq for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2024 02:52:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=pRdyPdI7/TpNuelTVATMhQFTtqz1MkWaTn4JdSlUcHM=; b=ZDHWxwIxi3iWHDE5MQumki7BsLw/u4BzFYQM/+wP+t8FWSXeNlgXhxubmGzxKa0+ZOVMipgGQD4pRv67LUEvxJS0tA0DW1Z+zHNsEXHT0qO/dEhK2Fynysln7dlCGnl24FQni3q7bTaWpfErTKXtCDSYePcilc5ddmOsPts3jvsHLmZSYbhahK/5thX1ODdjCcKlqJQ846d/Yahq95dv9be2fhIZsIN4orkcKrrqxzT6iBHsFLumUFllRzEdwJN885T3k3AmwAs8S0I9mr5zfUQQgI1XWAIGM5T9kSp95iMMfjDtEsuRZOfxu5QDE7cLWdo7feyzT85N14PRKrAlsg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1swFgw-0008SU-C4 for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2024 02:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2024 06:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73604 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73604-submit@debbugs.gnu.org id=B73604.172793827332445 (code B ref 73604); Thu, 03 Oct 2024 06:52:02 +0000 Original-Received: (at 73604) by debbugs.gnu.org; 3 Oct 2024 06:51:13 +0000 Original-Received: from localhost ([127.0.0.1]:59789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swFg9-0008RE-CK for submit@debbugs.gnu.org; Thu, 03 Oct 2024 02:51:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swFg5-0008R0-Te for 73604@debbugs.gnu.org; Thu, 03 Oct 2024 02:51:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swFfw-0000Oy-Ty; Thu, 03 Oct 2024 02:51:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pRdyPdI7/TpNuelTVATMhQFTtqz1MkWaTn4JdSlUcHM=; b=qhnCmeu/+sUb e4xGuVpYzaZ88dE0Ne6y/cRRQ+VQ9/JcLc4SH4GgqKe7m2IxU6v5pJAz4OrQg1Wav7KcWSpzhruc4 9Sssg3NuFuwk7Rfs7jtAAc0olV6jpl+SKHpJjRtIYfEcL1V9qC+8Vi5+zllM756kLYPlJemTJba6h mLeEFZSR7NZnChkGOEjvYdmfGgsBb4jMLTx07xr2JOQmOEaiBI4sh2WkhjA8Va1Fy3DWFnIBsCgGr M1pd01Odo1UGoNGdmSrLorDHn3TquQZows54GGCJ469ZQ80GBn0lzxuYcETnuCZlDOyJVJCmdKbFY Cg7VsY4enSX4BSNIVyKj2g==; In-Reply-To: <87o7422any.fsf@melete.silentflame.com> (message from Sean Whitton on Thu, 03 Oct 2024 10:16:33 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292886 Archived-At: > From: Sean Whitton > Cc: Spencer Baugh , 73604@debbugs.gnu.org > Date: Thu, 03 Oct 2024 10:16:33 +0800 > > Eli, can this go on emacs-30? Why is it important enough to install on emacs-30? The situation sounds quite rare to me. Moreover, I'm not sure the change is correct in general. If you invoke "C-x v l" with an argument, the prompt says "...(default: last revision)". It says "last", and doesn't say anything about the working revision. So I don't understand why you say the current operation of the command is incorrect even when the tip and the current working revision are different. I think this is precisely a use case where the user should invoke the command with a prefix arg and specify the revision from which to start. Am I missing something?