all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Cecilio Pardo <cpardo@imayhem.com>
Cc: 73730-done@debbugs.gnu.org
Subject: bug#73730: 31.0.50; Support for color fonts on MS-Windows
Date: Fri, 25 Oct 2024 14:51:53 +0300	[thread overview]
Message-ID: <86o738bdt2.fsf@gnu.org> (raw)
In-Reply-To: <68b9d35b-b8e1-4830-8ad9-8c33258e0980@imayhem.com> (message from Cecilio Pardo on Thu, 24 Oct 2024 22:19:06 +0200)

> Date: Thu, 24 Oct 2024 22:19:06 +0200
> From: Cecilio Pardo <cpardo@imayhem.com>
> 
> New version attached.
> 
> - Added comments
> - Use SAFE_ALLOCA instead of alloca.
> - Added two lisp functions:
>    w32-dwrite-available to find out is dwrite is working
>    w32-dwrite-reinit to reinitialize dwrite, optionally
>    changing render parameters (gamma, cleartype level, contrast).
>    Can go back to defaults passing nil.
> - Updated NEWS and changelog.

Thanks, installed on the master branch, and closing the bug.

I also installed minor followup changes:

I removed the eassert from this fragment:

  /* IDWriteFactory2 is only available on Windows 8.1 and later.
     Without this, we can't use color fonts.  So we disable DirectWrite
     if it is not available.  */
  hr = dwrite_factory->lpVtbl->QueryInterface (dwrite_factory,
					       &IID_IDWriteFactory2,
					       (void **) &dwrite_factory2);

  if (FAILED (hr))
    {
      DebPrint (("DirectWrite HRESULT failed: (%d) QueryInterface IDWriteFactory2\n", hr));
      RELEASE_COM (dwrite_factory);
      FreeLibrary (direct_write);
      return;
    }

That's because otherwise the debug build of Emacs will abort on
Windows 7 and 8.0, which is not what we want.

Also, I've added some information about the default values of the
parameters to the doc string of w32-dwrite-reinit; please see if I
made some mistakes there, as the default values don't seem to be
documented anywhere I could see.





  parent reply	other threads:[~2024-10-25 11:51 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-10 11:16 bug#73730: 31.0.50; Support for color fonts on MS-Windows Cecilio Pardo
2024-10-10 13:08 ` Eli Zaretskii
2024-10-10 15:14   ` Cecilio Pardo
2024-10-10 16:33     ` Eli Zaretskii
2024-10-10 16:46       ` Cecilio Pardo
2024-10-15 22:18   ` Cecilio Pardo
2024-10-16 11:01     ` Eli Zaretskii
2024-10-16 11:32       ` Eli Zaretskii
2024-10-16 21:35       ` Cecilio Pardo
2024-10-17  6:21         ` Eli Zaretskii
2024-10-17 10:38           ` Cecilio Pardo
2024-10-20 13:35             ` Cecilio Pardo
2024-10-20 13:55               ` Eli Zaretskii
2024-10-22 22:14                 ` Cecilio Pardo
2024-10-23 10:03                   ` Eli Zaretskii
2024-10-23 14:17                     ` Cecilio Pardo
2024-10-23 17:53                       ` Eli Zaretskii
2024-10-24 20:19                         ` Cecilio Pardo
2024-10-25  7:26                           ` Eli Zaretskii
2024-10-25 10:17                             ` Cecilio Pardo
2024-10-25 12:00                               ` Eli Zaretskii
2024-10-26 20:13                                 ` Cecilio Pardo
2024-10-27  6:36                                   ` Eli Zaretskii
2024-10-27 13:32                                     ` Eli Zaretskii
2024-10-27 13:41                                       ` Cecilio Pardo
2024-10-27 15:44                                       ` Cecilio Pardo
2024-10-27 16:54                                         ` Eli Zaretskii
2024-10-27 17:50                                           ` Cecilio Pardo
2024-10-27 19:15                                             ` Eli Zaretskii
2024-10-29  8:57                                               ` Cecilio Pardo
2024-10-25 11:51                           ` Eli Zaretskii [this message]
2024-10-25 13:43                             ` Cecilio Pardo
2024-10-20 16:17               ` Eli Zaretskii
2024-10-20 18:20                 ` Cecilio Pardo
2024-10-20 18:33                   ` Eli Zaretskii
2024-10-20 18:37                     ` Cecilio Pardo
2024-10-10 21:50 ` Cecilio Pardo
2024-10-11  3:36   ` Eli Zaretskii
2024-10-11  6:28     ` Eli Zaretskii
2024-10-11  7:19       ` Cecilio Pardo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86o738bdt2.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=73730-done@debbugs.gnu.org \
    --cc=cpardo@imayhem.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.