From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 298bbf3cd76: * lisp/files.el (major-mode-remap-alist): Add :tag annotations to :type. Date: Wed, 27 Nov 2024 16:56:14 +0200 Message-ID: <86o720g1yp.fsf@gnu.org> References: <173265864560.3782512.13226573513692541017@vcs3.savannah.gnu.org> <20241126220406.17BD64E19C6@vcs3.savannah.gnu.org> <87o721f4ac.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12261"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, dmitry@gutov.dev To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 27 15:57:14 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tGJTd-0002wb-Ed for ged-emacs-devel@m.gmane-mx.org; Wed, 27 Nov 2024 15:57:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tGJSo-0004bM-DR; Wed, 27 Nov 2024 09:56:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGJSm-0004bB-NR for emacs-devel@gnu.org; Wed, 27 Nov 2024 09:56:21 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGJSm-000447-5Y; Wed, 27 Nov 2024 09:56:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QQr2t7eBA7H3JWvIBRf79mDY5mJimnxwwmoNB3M7gFg=; b=QvhVVEYQpSSI 8JvvqOn2FrDKJEsdWvFZzT8C0yr4/DkcSs3D21Gb5TV9S2NERKcwrV2jnKmWMyXLINMsCqJ0fLMTn v5oqOd3u/f6jooUdq0JlsplCKXKNZPyry7jVJtIbCO+cgm4AYWVL6rfJ+3F1GKdSJpGVdeMae2Fls fccbA2aXo2zTp5dwNETSkcZ9Tr4GB8drIKeJp5tXrP7Gr58z2PWY2GA28k8qO423+ELYjR6J0Fq0A SVPe0RbbrHBTUCA+G9bixmFZ93BfixvBK9b0NGb/nGWbXwX9n/KGFl/PXUWMgsWeGbGQu7e5O4HA2 IM3+ELHnPg+c92bNqAX5Rw==; In-Reply-To: <87o721f4ac.fsf@gmail.com> (message from Robert Pluim on Wed, 27 Nov 2024 09:51:23 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325772 Archived-At: > From: Robert Pluim > Cc: Dmitry Gutov > Date: Wed, 27 Nov 2024 09:51:23 +0100 > > >>>>> On Tue, 26 Nov 2024 17:04:05 -0500 (EST), Dmitry Gutov said: > > Dmitry> branch: master > Dmitry> commit 298bbf3cd76ffaf0c88a6a9ec56aa33c4103b8e6 > Dmitry> Author: Dmitry Gutov > Dmitry> Commit: Dmitry Gutov > > Dmitry> * lisp/files.el (major-mode-remap-alist): Add :tag annotations to :type. > Dmitry> --- > Dmitry> lisp/files.el | 5 ++++- > Dmitry> 1 file changed, 4 insertions(+), 1 deletion(-) > > Dmitry> diff --git a/lisp/files.el b/lisp/files.el > Dmitry> index 72f3604054e..a65bc4a4ea2 100644 > Dmitry> --- a/lisp/files.el > Dmitry> +++ b/lisp/files.el > Dmitry> @@ -3621,7 +3621,10 @@ instead. > Dmitry> FUNCTION is typically a major mode which \"does the same thing\" as > Dmitry> MODE, but can also be nil to hide other entries (either in this var or > Dmitry> in `major-mode-remap-defaults') and means that we should call MODE." > Dmitry> - :type '(alist (symbol) (function))) > Dmitry> + :type '(alist > Dmitry> + :tag "Remappings" > Dmitry> + :key-type (symbol :tag "From major mode") > Dmitry> + :value-type (function :tag "To mode (or function)"))) > > Is this close enough to a documentation change that we could apply it > to emacs-30? I don't mind backporting it, but it sounds like Juri was not happy with some aspect of the change?