all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org, dmitry@gutov.dev
Subject: Re: master 298bbf3cd76: * lisp/files.el (major-mode-remap-alist): Add :tag annotations to :type.
Date: Wed, 27 Nov 2024 16:56:14 +0200	[thread overview]
Message-ID: <86o720g1yp.fsf@gnu.org> (raw)
In-Reply-To: <87o721f4ac.fsf@gmail.com> (message from Robert Pluim on Wed, 27 Nov 2024 09:51:23 +0100)

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Dmitry Gutov <dmitry@gutov.dev>
> Date: Wed, 27 Nov 2024 09:51:23 +0100
> 
> >>>>> On Tue, 26 Nov 2024 17:04:05 -0500 (EST), Dmitry Gutov <dgutov@yandex.ru> said:
> 
>     Dmitry> branch: master
>     Dmitry> commit 298bbf3cd76ffaf0c88a6a9ec56aa33c4103b8e6
>     Dmitry> Author: Dmitry Gutov <dmitry@gutov.dev>
>     Dmitry> Commit: Dmitry Gutov <dmitry@gutov.dev>
> 
>     Dmitry>     * lisp/files.el (major-mode-remap-alist): Add :tag annotations to :type.
>     Dmitry> ---
>     Dmitry>  lisp/files.el | 5 ++++-
>     Dmitry>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
>     Dmitry> diff --git a/lisp/files.el b/lisp/files.el
>     Dmitry> index 72f3604054e..a65bc4a4ea2 100644
>     Dmitry> --- a/lisp/files.el
>     Dmitry> +++ b/lisp/files.el
>     Dmitry> @@ -3621,7 +3621,10 @@ instead.
>     Dmitry>  FUNCTION is typically a major mode which \"does the same thing\" as
>     Dmitry>  MODE, but can also be nil to hide other entries (either in this var or
>     Dmitry>  in `major-mode-remap-defaults') and means that we should call MODE."
>     Dmitry> -  :type '(alist (symbol) (function)))
>     Dmitry> +  :type '(alist
>     Dmitry> +          :tag "Remappings"
>     Dmitry> +          :key-type (symbol :tag "From major mode")
>     Dmitry> +          :value-type (function :tag "To mode (or function)")))
> 
> Is this close enough to a documentation change that we could apply it
> to emacs-30?

I don't mind backporting it, but it sounds like Juri was not happy
with some aspect of the change?



      reply	other threads:[~2024-11-27 14:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <173265864560.3782512.13226573513692541017@vcs3.savannah.gnu.org>
     [not found] ` <20241126220406.17BD64E19C6@vcs3.savannah.gnu.org>
2024-11-27  8:51   ` master 298bbf3cd76: * lisp/files.el (major-mode-remap-alist): Add :tag annotations to :type Robert Pluim
2024-11-27 14:56     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86o720g1yp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=emacs-devel@gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.