From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Prefer to split along the longest edge Date: Tue, 17 Dec 2024 14:59:34 +0200 Message-ID: <86o71ao47d.fsf@gnu.org> References: <87r06a3yfg.fsf@mail.linkov.net> <87zfkx2ydr.fsf@mail.linkov.net> <8734io2hac.fsf@mail.linkov.net> <86pllrpn2p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28739"; mail-complaints-to="usenet@ciao.gmane.io" Cc: juri@linkov.net, emacs-devel@gnu.org To: Nicolas =?utf-8?Q?Despr=C3=A8s?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 17 14:00:28 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNXBc-0007Jz-7c for ged-emacs-devel@m.gmane-mx.org; Tue, 17 Dec 2024 14:00:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNXAq-0002mk-Ox; Tue, 17 Dec 2024 07:59:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNXAo-0002mZ-VM for emacs-devel@gnu.org; Tue, 17 Dec 2024 07:59:39 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNXAo-000627-JN; Tue, 17 Dec 2024 07:59:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=M57JDyi88SuL5p2wFA/HwLjQ+14BJvBDJEWJ1/F2J5s=; b=K7Bp49YAldhKWLf5rRFc X/ysGm/FQfnUnzwctUoUEFU4PgJT2X72kzhOnNiXqkxVhma2AODSXuWiGNAntq8pQaAIHh7ZWTKM3 6w6rVu5Wy2LJcL6ELDCTNGf9dKJySEgUIb8CmQQL9QAAsN26b8Yh2U7UvomgL0vm9WvrO47KmVOpi zl9PszYBhVc9Xy2J92DGltjxqc37GhAhmvV15kT+REaylOJTV4jGJuLX3eg44T8D3IhX3waD7HosV kqYmxH3CO/LNTorFUVsntcES1eZ5/+x5SRUuvwVCnXJnH/4jMDZvRoKupHSdeymGJ2l+Jq3e9KX4N 7e0yD8sTgNslCQ==; In-Reply-To: (message from Nicolas =?utf-8?Q?Despr=C3=A8s?= on Tue, 17 Dec 2024 07:06:07 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326589 Archived-At: > From: Nicolas Desprès > Date: Tue, 17 Dec 2024 07:06:07 +0100 > Cc: juri@linkov.net, emacs-devel@gnu.org > > I have attached a new patch that should address all your remarks. Thanks. > @@ -519,7 +520,9 @@ Window Choice > @code{split-width-threshold} is smaller than the window's width, the > split puts the new window on the right. If neither condition holds, > Emacs tries to split so that the new window is below---but only if the > -window was not split before (to avoid excessive splitting). > +window was not split before (to avoid excessive splitting). Whether ^^ Our convention is to leave two spaces between sentences. (The same is true for the text in the commit log messages.) > ++++ > +*** New user option 'preferred-split-edge'. > +Users can now choose which edge (vertical or horizontal) is tried to be > +split first. With this new setting, when the frame is in landscape shape > +for instance, Emacs could split horizontally before to split vertically. This should say what is the default behavior. > +(defcustom preferred-split-edge 'vertical > + "The edge that `split-window-sensibly' will try to split first. > +This order matter when both edges can be split according to > +`split-width-threshold' and `split-height-threshold'." This doc string should explain the meaning of each value. (Yes, I know that the text which describes each option does, but that doesn't help when the user reads the doc string shown by "C-h v", for example.) > + :type '(choice > + (const :tag "Try to split vertically first (legacy behavior)" > + vertical) > + (const :tag "Try to split horizontally first" > + horizontal) > + (const :tag "Try to split along the longest edge first" > + longest)) > + :version "30.1" ^^^^^^^^^^^^^^ This should be "31.1".