From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#75123: [PATCH] Set makeinfo-run-command to texi2any when possible Date: Fri, 27 Dec 2024 14:55:48 +0200 Message-ID: <86o70xwai3.fsf@gnu.org> References: <86ed1ty4r8.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38987"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75123@debbugs.gnu.org To: stefankangas@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 27 13:56:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tR9t5-0009wg-RA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Dec 2024 13:56:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tR9sr-000724-Fy; Fri, 27 Dec 2024 07:56:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tR9sp-00071n-2G for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 07:56:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tR9so-0002HH-Mt for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 07:56:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=e04LvUgyfMbGEkzay0OwIQOhFctTIiMtZvpBZepp8wM=; b=V1jQNlDtTz1lUTJ5OSO32MWnbidXck9ezAw8PiKl6fQe7lCneyuW7bCNdoe1nDdhV72GTJG4tVa2lUz5sD995XkEAD8Tcm/TY4GIX6FjAWOVCRPybNaLXz1LqVlkabWNiBn7VKEm/O6cGtLeQp/qgRjgQVMJWvY9FuxXb4rU0pMac9tO99qFCgCwXDUntM0fIg+RCF+MeoU0Y1dLM51JHOiwXg2823LH68BTXdmeft3ktQpXUza7s6kbefms1OgzkOeRVZu+vLerzdgiwOQ3ErIj2atVkv1COMjUf25etQTu8Rp7NFdmFknKy8Ya2f8/ovTHNiWABHHDJs1iwottzw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tR9so-0007X1-Hd for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 07:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Dec 2024 12:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75123 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 75123-submit@debbugs.gnu.org id=B75123.173530416128943 (code B ref 75123); Fri, 27 Dec 2024 12:56:02 +0000 Original-Received: (at 75123) by debbugs.gnu.org; 27 Dec 2024 12:56:01 +0000 Original-Received: from localhost ([127.0.0.1]:45007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tR9sm-0007Wj-Gg for submit@debbugs.gnu.org; Fri, 27 Dec 2024 07:56:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tR9sk-0007WP-15 for 75123@debbugs.gnu.org; Fri, 27 Dec 2024 07:55:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tR9se-0002FE-Je; Fri, 27 Dec 2024 07:55:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=e04LvUgyfMbGEkzay0OwIQOhFctTIiMtZvpBZepp8wM=; b=C6KbJHYeLWig /80oTO1lfwPrAzyNkdu4LGobubpBm4t1F1hvV64JjD0SYxhWPnYW4G54eP4TYPb2agr78MfOc4OzG K6duoilABkxGaSSqdgXFKAVuuOXm1rYIGu11mZH0PX3cWxbDil9bpY3tGTMiXsAlLG6m38k057xyu /C+3OVchDh5Om0j0sUJryr8irT5eDqb5b4gVP2JGauy1YAP4zwtc72Q4lqXj1PRVXl5RTIg2cVRuR +iJuDx1hAMvj9u0kOuzr2Y4i/NSO5GhIXwllNV8DoEcrc3gO9Mve/ZmZaud5s8myj8NgAJURwyO6r RT6HZBrVOgw6vN74hfd/Xg==; In-Reply-To: <86ed1ty4r8.fsf@gnu.org> (message from Eli Zaretskii on Fri, 27 Dec 2024 09:16:59 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297823 Archived-At: > Cc: 75123@debbugs.gnu.org > Date: Fri, 27 Dec 2024 09:16:59 +0200 > From: Eli Zaretskii > > > In recent Texinfo, "makinfo" is an alias for "texi2any". Make > > `makeinfo-run-command` heed this request in the texinfo documentation: > > > > "Going forward, we ask authors of Texinfo documents to use only > > texi2any." > > > > See (info "(texinfo) History"). > > Sorry, I'm against this change. People still have old versions of > Texinfo installed, including those where texi2any was not even > present. I understand what the Texinfo developers say as advice to > people who install latest version of Texinfo, not as a general rule to > other programs which invoke makeinfo. > > In practice, in latest versions, 'makeinfo' is just a copy (or even a > symlink) to texi2any. So we gain absolutely nothing by this change, > while the disadvantages for users who have old versions of makeinfo > are clear and present. A few more thoughts: Some users could have local scripts named "makeinfo" somehow tailored to DTRT for whatever reasons. Invoking texi2any instead will break those users, for no good reason. In addition, executable-find looks for files with extensions in the order specified by exec-suffixes, which could be different from the order the shell looks for executables. So this change might produce subtle differences in behavior, at least in some cases. I could support doing this the other way around: if "makeinfo" is not found as an executable, fall back to texi2any (if that exists). But in that case, we need to make sure makeinfo-run-command never ends up being nil, because AFAICT the code is not prepared for that. IOW, if neither "makeinfo" nor "texi2any" is found, the value should be "makeinfo", as it was before, not nil.