From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Adding git-commit highlight mode? Date: Sat, 04 Jan 2025 09:17:06 +0200 Message-ID: <86o70nf3pp.fsf@gnu.org> References: <37733be4476e1c2b6e873c967c79cb0035959a9e.camel@yandex.ru> <86wmfdhwg7.fsf@gnu.org> <0347118b217c57e4e62018547883fad5f1d1e63e.camel@yandex.ru> <86r05lht77.fsf@gnu.org> <875xmwykuk.fsf@aarsen.me> <87ed1j8vc2.fsf@zephyr.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="318"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, arsen@aarsen.me, Hi-Angel@yandex.ru, emacs-devel@gnu.org, jporterbugs@gmail.com To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 04 08:17:54 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTyPy-000AUi-DU for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Jan 2025 08:17:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTyPJ-0005t8-UQ; Sat, 04 Jan 2025 02:17:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTyPH-0005rq-Qr for emacs-devel@gnu.org; Sat, 04 Jan 2025 02:17:12 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTyPF-0006jR-HE; Sat, 04 Jan 2025 02:17:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fadQo+a/rVXSLLzQVrvt782T1athGVncgePG15evdp0=; b=FBgmc35AD+Xf cWHknGRvhjNyTMZIq2u7/6UMkyhLoQUkAYfRlNHv8sINa0ujLMwSYyfv2hR0T540VgdwRIvIp23lG P8WI/ccnBHPGFk12Ioj8mRnu//EOVt4sL3q8EXJDS7Dr6qPUttayjOh//NPaQvYUPujQBZtepBCtT 88paETbDU3hjsNeJa2wykRl3Wn4KzRL4zZLqo6e1r+59m1Z72oIAu/nt9+98C4YEL3R3KuHKR6FCh 9UqyldqbPcaNLN/b+N4ZtNurpfoambTa+dr+ym0GPEqtftfFR2kWu88r3ueuxYhbK4POjalY93cDU 054DEUVJepx7Q/1Uaj5Eiw==; In-Reply-To: <87ed1j8vc2.fsf@zephyr.silentflame.com> (message from Sean Whitton on Fri, 03 Jan 2025 21:02:21 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327652 Archived-At: > From: Sean Whitton > Date: Fri, 03 Jan 2025 21:02:21 +0000 > > Hello, > > On Thu 02 Jan 2025 at 03:53pm -06, Stefan Kangas wrote: > > > AFAICT, the 50 character line limit for the summary line is not really > > followed very strictly in practice by most projects, including the Linux > > kernel. It's more of a recommendation. Even the link you provide above > > says that it's "a good idea" to use "no more than 50 characters" for it. > > For that reason, I think that this should be a warning (with a highlight > > if you go over), and not a hard limit. > > > > In `git-commit-mode`, the user option `git-commit-summary-max-length' is > > 68 by default, which strikes me as unopinionated enough. > > As Jonas mentioned, some of the things suggested in this thread overlap > with our existing vc-git-log-edit-mode. For example, we already have > vc-git-log-edit-summary-target-len and vc-git-log-edit-summary-max-len. vc-git-log-edit-mode kicks in only if one commits using VC commands. It will not kick in if, for example, one commits from the shell prompt with GIT_EDITOR set to invoke emacsclient. So there's still a place for a mode that is turned on when Emacs needs to edit the files with special names used by Git for some of the activities. > (As the VC maintainer, I would have appreciated being CC'd on this > thread at some point; glad I caught it anyway.) The thread was not about VC (still isn't, AFAICT), so it is not surprising you were not CC'ed.