From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Chris Zheng Newsgroups: gmane.emacs.bugs Subject: bug#28097: 26.0.50; Commit 9746058 breaks build on MS-Windows Date: Tue, 15 Aug 2017 22:45:06 +0800 Message-ID: <86mv70houl.wl-chriszheng99@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-2022-JP X-Trace: blaine.gmane.org 1502808469 7064 195.159.176.226 (15 Aug 2017 14:47:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 15 Aug 2017 14:47:49 +0000 (UTC) User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) To: 28097@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 15 16:47:42 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhd82-00010u-Vc for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Aug 2017 16:47:35 +0200 Original-Received: from localhost ([::1]:38477 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhd89-0000E2-ED for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Aug 2017 10:47:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhd6d-0007hu-AH for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 10:46:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhd6Y-0006IC-AZ for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 10:46:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57600) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhd6Y-0006I5-7R for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 10:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dhd6Y-0006mG-0c for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 10:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chris Zheng Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Aug 2017 14:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28097 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.150280833726016 (code B ref -1); Tue, 15 Aug 2017 14:46:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Aug 2017 14:45:37 +0000 Original-Received: from localhost ([127.0.0.1]:38037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhd68-0006lY-Od for submit@debbugs.gnu.org; Tue, 15 Aug 2017 10:45:36 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39091) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhd67-0006lS-57 for submit@debbugs.gnu.org; Tue, 15 Aug 2017 10:45:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhd61-0005Rw-1d for submit@debbugs.gnu.org; Tue, 15 Aug 2017 10:45:29 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:46116) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dhd60-0005RW-U7 for submit@debbugs.gnu.org; Tue, 15 Aug 2017 10:45:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhd5z-00079D-Pe for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 10:45:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhd5u-0005Ih-RK for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 10:45:27 -0400 Original-Received: from mail-pg0-x236.google.com ([2607:f8b0:400e:c05::236]:32944) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhd5u-0005Fn-L7 for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2017 10:45:22 -0400 Original-Received: by mail-pg0-x236.google.com with SMTP id u5so6940544pgn.0 for ; Tue, 15 Aug 2017 07:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:subject:user-agent:mime-version; bh=hIrSyFkpSd+fAXPbi+P7XpEFVoJ6C7qvGzTnwwnUniM=; b=qiSFq2bz0OX5kTVaVjGHzfJu+j4a/3u+pIVY/xCdF4RXgE6Yo2hYXJEMvx16LqqU7U 803QyQqRlrKNc5u0060gMf0m/ydDaSwqsMTcpci54ejmid/i1VoYjK1mTUYDnVBoZ53r En6/uqV+AkhHYjkdYJxlh01/MHMn7bXS5s6W8DaVY8DnQFYTjE9gxnnPU2uWzsxVmYaX sHiYW40ROaAKyPSZnD3j854Jc9WeI/CUkFCiZQZABTMvO7b6l2a/h3AEl9FkRe5wIrJ2 J1syjSzjZhP1VZKvZ5c7Sqw7NGYH+Jo1oSiSr8NHzCwF5aRDGoMR1NLNytVSzrZhMZ5M 1lLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:subject:user-agent :mime-version; bh=hIrSyFkpSd+fAXPbi+P7XpEFVoJ6C7qvGzTnwwnUniM=; b=WYoba52fByT6KqhqJZgkJs4Do0HHm5mNBfePoe3d1iCIZNDVmMEZkIU+jveqomSxtr 4rukcemmAktfGV1g9zUy6+kX43TokLP9zSWt88Ebzks9dWDZ00QuFC2SMER18ClWBJMN alkMTOBYXMGNIs9iAGYNWVa6efxSDteBNgAlaCD0pK55RY9+rFa6LUWGH1zvxJ/+h4L5 dvwGDszbNZ6vxfoPg7xpymDZmPSR/9wK06GTETfPOkhRuGYBrk+1gWcjOQb/V4GyJoQ6 ooyD3fOdFRHFXov7wfyW3yX3E8El1Ssbuq9CpHaYxjubx/+Cd1k96DEG2tjn8NiHaMjO oQBw== X-Gm-Message-State: AHYfb5gTyMMiN5Ks7dQ/LJ/KjlgR69/Z6NcNgpfssJ2GIGkX/uBauhU6 yXbxXZz5SI1vld+8 X-Received: by 10.98.73.198 with SMTP id r67mr29424467pfi.83.1502808319814; Tue, 15 Aug 2017 07:45:19 -0700 (PDT) Original-Received: from Kael.gmail.com (104.224.170.13.16clouds.com. [104.224.170.13]) by smtp.gmail.com with ESMTPSA id y87sm18507364pfa.41.2017.08.15.07.45.18 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Aug 2017 07:45:19 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135774 Archived-At: The error message is fileio.c: In function 'Frename_file': fileio.c:2300:41: error: duplicate case value case EEXIST: case EINVAL: case ENOSYS: case ENOTSUP: ^~~~ fileio.c:2300:28: note: previously used here case EEXIST: case EINVAL: case ENOSYS: case ENOTSUP: ^~~~ Because the file nt/inc/ms-w32.h, line 389, has the definition “#define ENOTSUP ENOSYS” and it is included early than errno.h which has the right define. One possible fix is is @@ -2297,7 +2297,10 @@ This is what happens in interactive use with M-x. */) rename_errno = errno; switch (rename_errno) { - case EEXIST: case EINVAL: case ENOSYS: case ENOTSUP: + case EEXIST: case EINVAL: case ENOSYS: +#ifdef DARWIN_OS + case ENOTSUP: +#endif barf_or_query_if_file_exists (newname, rename_errno == EEXIST, "rename to it", INTEGERP (ok_if_already_exists), Or we can change the #define in ms-w32.h. Could you please have a look on it? Thank you, Chris