all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chris Zheng <chriszheng99@gmail.com>
To: 28097@debbugs.gnu.org
Subject: bug#28097: 26.0.50; Commit 9746058 breaks build on MS-Windows
Date: Tue, 15 Aug 2017 22:45:06 +0800	[thread overview]
Message-ID: <86mv70houl.wl-chriszheng99@gmail.com> (raw)


The error message is

fileio.c: In function 'Frename_file':
fileio.c:2300:41: error: duplicate case value
  case EEXIST: case EINVAL: case ENOSYS: case ENOTSUP:
                                         ^~~~
fileio.c:2300:28: note: previously used here
  case EEXIST: case EINVAL: case ENOSYS: case ENOTSUP:
                            ^~~~

Because the file nt/inc/ms-w32.h, line 389, has the definition
“#define ENOTSUP ENOSYS” and it is included early than errno.h
which has the right define. One possible fix is is

@@ -2297,7 +2297,10 @@ This is what happens in interactive use with M-x.  */)
       rename_errno = errno;
       switch (rename_errno)
 	{
-	case EEXIST: case EINVAL: case ENOSYS: case ENOTSUP:
+	case EEXIST: case EINVAL: case ENOSYS:
+#ifdef DARWIN_OS
+	case ENOTSUP:
+#endif
 	  barf_or_query_if_file_exists (newname, rename_errno == EEXIST,
 					"rename to it",
 					INTEGERP (ok_if_already_exists),

Or we can change the #define in ms-w32.h.

Could you please have a look on it?

Thank you,
Chris






             reply	other threads:[~2017-08-15 14:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15 14:45 Chris Zheng [this message]
2017-08-15 16:19 ` bug#28097: 26.0.50; Commit 9746058 breaks build on MS-Windows Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86mv70houl.wl-chriszheng99@gmail.com \
    --to=chriszheng99@gmail.com \
    --cc=28097@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.