From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Suspicious warning in W64 build Date: Sat, 16 Sep 2017 14:17:15 +0100 Message-ID: <86mv5ulr50.fsf@gmail.com> References: <1017454172.910810.1504618695244@mail.libero.it> <102a4c21-c275-c73e-ec53-0d85975dc968@cs.ucla.edu> <83a825znuf.fsf@gnu.org> <831snhzkgw.fsf@gnu.org> <837ex9x7vf.fsf@gnu.org> <83tw0cwcle.fsf@gnu.org> <83h8wcw3td.fsf@gnu.org> <83377vx3d0.fsf@gnu.org> <83ingnq01t.fsf@gnu.org> <83fubrpxsv.fsf@gnu.org> <83r2v9masw.fsf@gnu.org> <86a81xrndl.fsf@gmail.com> <83a81wmijy.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505567854 24167 195.159.176.226 (16 Sep 2017 13:17:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Sep 2017 13:17:34 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 16 15:17:30 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtCyP-0006Ad-F3 for ged-emacs-devel@m.gmane.org; Sat, 16 Sep 2017 15:17:29 +0200 Original-Received: from localhost ([::1]:57314 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtCyW-0001iB-O5 for ged-emacs-devel@m.gmane.org; Sat, 16 Sep 2017 09:17:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtCyM-0001bP-KY for emacs-devel@gnu.org; Sat, 16 Sep 2017 09:17:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtCyL-0002Op-Ky for emacs-devel@gnu.org; Sat, 16 Sep 2017 09:17:26 -0400 Original-Received: from [195.159.176.226] (port=60422 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dtCyL-0002O2-Cp for emacs-devel@gnu.org; Sat, 16 Sep 2017 09:17:25 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dtCyB-0005mK-5F for emacs-devel@gnu.org; Sat, 16 Sep 2017 15:17:15 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 36 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:5vF6HMF08iXYgZdRoaU1fnWdcEI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218357 Archived-At: On Fri 15 Sep 2017, Eli Zaretskii wrote: >> From: Fabrice Popineau >> Date: Fri, 15 Sep 2017 08:55:06 +0200 >> Cc: Emacs developers >> >> # define pDWP "16llx" >> ^ >> >> Should these be using the ptrdiff_t formatter pD from lisp.h ? >> >> I'd rather cast the values to "long long unsigned int" as these values are assumed to be positive, >> and would be meaningless if printed in decimal. > > That's what I did. The Mingw64 32bit build still has warnings in unexw32.c, which the following fixes: diff --git a/src/unexw32.c b/src/unexw32.c index 0c6b48342e..e97a52ba07 100644 --- a/src/unexw32.c +++ b/src/unexw32.c @@ -471,7 +471,7 @@ get_section_info (file_data *p_infile) } /* Format to print a DWORD_PTR value. */ -#ifdef MINGW_W64 +#if defined MINGW_W64 && defined _WIN64 # define pDWP "16llx" #else # define pDWP "08lx" With this change I get clean builds on mingw64 32bit and 64bit. AndyM