From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: patch gud-gdb to respect other-frame-window? Date: Sun, 29 Jul 2018 12:22:55 -0500 Message-ID: <86muuaq7m8.fsf@stephe-leake.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1532884909 1815 195.159.176.226 (29 Jul 2018 17:21:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jul 2018 17:21:49 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 29 19:21:45 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjpO5-0000PJ-2r for ged-emacs-devel@m.gmane.org; Sun, 29 Jul 2018 19:21:45 +0200 Original-Received: from localhost ([::1]:49155 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjpQB-0005Dx-TX for ged-emacs-devel@m.gmane.org; Sun, 29 Jul 2018 13:23:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjpPM-0005D5-Gv for emacs-devel@gnu.org; Sun, 29 Jul 2018 13:23:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjpPJ-0002rm-Cp for emacs-devel@gnu.org; Sun, 29 Jul 2018 13:23:04 -0400 Original-Received: from smtp97.ord1d.emailsrvr.com ([184.106.54.97]:36897) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fjpPJ-0002rE-84 for emacs-devel@gnu.org; Sun, 29 Jul 2018 13:23:01 -0400 Original-Received: from smtp13.relay.ord1d.emailsrvr.com (localhost [127.0.0.1]) by smtp13.relay.ord1d.emailsrvr.com (SMTP Server) with ESMTP id B9EF4C013F for ; Sun, 29 Jul 2018 13:22:58 -0400 (EDT) X-Auth-ID: board-president@tomahawk-creek-hoa.com Original-Received: by smtp13.relay.ord1d.emailsrvr.com (Authenticated sender: board-president-AT-tomahawk-creek-hoa.com) with ESMTPSA id 8801CC013B for ; Sun, 29 Jul 2018 13:22:58 -0400 (EDT) X-Sender-Id: board-president@tomahawk-creek-hoa.com Original-Received: from Takver4 (76-218-37-33.lightspeed.kscymo.sbcglobal.net [76.218.37.33]) (using TLSv1.2 with cipher AES256-GCM-SHA384) by 0.0.0.0:25 (trex/5.7.12); Sun, 29 Jul 2018 13:22:58 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 184.106.54.97 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227951 Archived-At: Currently, 'gud-gdb' has its own notion of where to put the *gud-* buffer. Since I use other-frame-window (a GNU ELPA package), I'd like to override that. This patch works for me: diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el index 6826674a94..1b5cf46231 100644 --- a/lisp/progmodes/gud.el +++ b/lisp/progmodes/gud.el @@ -2608,9 +2608,11 @@ gud-common-init (select-window (display-buffer (get-buffer-create (concat "*gud" filepart "*")) - '(display-buffer-reuse-window - display-buffer-in-previous-window - display-buffer-same-window display-buffer-pop-up-window))) + (if (featurep 'other-frame-window) + '(display-buffer-same-window) + '(display-buffer-reuse-window + display-buffer-in-previous-window + display-buffer-same-window display-buffer-pop-up-window)))) (when (and existing-buffer (get-buffer-process existing-buffer)) (error "This program is already being debugged")) ;; Set the dir, in case the buffer already existed with a different dir. A similar pattern can be used for other commands that do not currently respect other-frame-window. Ok to commit to master? -- -- Stephe