From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#59962: 29.0.60; vc commands fail in diff-mode Date: Sun, 11 Dec 2022 19:28:06 +0200 Organization: LINKOV.NET Message-ID: <86mt7tlujd.fsf@mail.linkov.net> References: <87pmcqktzs.fsf@turtle.gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15862"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: svenjoac@gmx.de, mardani29@yahoo.es To: 59962@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 18:31:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4QAX-0003z1-8J for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 18:31:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4QAJ-0003rX-Sq; Sun, 11 Dec 2022 12:31:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4QAI-0003rN-AA for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 12:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4QAI-0002Eq-0z for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 12:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4QAH-0000ru-Tw for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 12:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 17:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59962 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: 59962@debbugs.gnu.org, Sven Joachim , Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Received: via spool by 59962-submit@debbugs.gnu.org id=B59962.167077981629614 (code B ref 59962); Sun, 11 Dec 2022 17:31:01 +0000 Original-Received: (at 59962) by debbugs.gnu.org; 11 Dec 2022 17:30:16 +0000 Original-Received: from localhost ([127.0.0.1]:47224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Q9X-0007gz-SO for submit@debbugs.gnu.org; Sun, 11 Dec 2022 12:30:16 -0500 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:56251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Q9W-0007GX-Uv for 59962@debbugs.gnu.org; Sun, 11 Dec 2022 12:30:15 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id C47BD100008; Sun, 11 Dec 2022 17:30:06 +0000 (UTC) In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?= via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Sun, 11 Dec 2022 17:46:47 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250632 Archived-At: >> As a distribution maintainer, I find myself working with >> version-controlled patches which Emacs visits in diff-mode. >> Unfortunately, there is a bad interaction between diff-mode and vc, >> which makes all vc commands fail. This is what I got on C-x v l: >> >> ,---- >> | Debugger entered--Lisp error: (wrong-type-argument arrayp nil) >> | file-truename(nil) >> | find-buffer-visiting(nil) >> | vc-buffer-sync-fileset((Git (nil nil nil nil) nil nil patch) t) >> | vc-diff(nil t) >> | funcall-interactively(vc-diff nil t) >> | call-interactively(vc-diff nil nil) >> | command-execute(vc-diff) >> `---- > > Could you detail the steps to reproduce this issue (preferably from > emacs -Q)? I've tried C-x v l on a few Git-version-controlled .patch > files (in Diff mode) but I couldn't reproduce the error. Thanks. The new feature of using 'C-x v v' on a diff buffer to commit it as a patch should not be used when the diff buffer is vc-controlled. This also means that 'C-x v v' on a file that even is not yet vc-controlled, after the recent fix will register the file in vcs, instead of committing it as a patch. 'C-x v v' for committing the patch will be supported only on non-file buffers.