From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#68244: hash-table improvements Date: Tue, 16 Jan 2024 21:57:04 +0000 Message-ID: <86mst5t00f.fsf@gmail.com> References: <170438379722.3921.9312235725296561206@vcs2.savannah.gnu.org> <20240104155642.B4A99C00344@vcs2.savannah.gnu.org> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@gutov.dev> <08314177-5AE9-4352-94A0-641830B4094D@gmail.com> <19265EA5-E6F3-446C-AD9B-763693CF0A48@gmail.com> <86cyu37elt.fsf@gmail.com> <83h6jeeq1z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11672"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 68244@debbugs.gnu.org Cancel-Lock: sha1:C4peRQfQ4GzAVnNOKZCRUqd/QHc= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 16 22:58:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rPrRs-0002p5-CY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Jan 2024 22:58:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rPrRc-00021k-Jm; Tue, 16 Jan 2024 16:58:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPrRa-000211-J7 for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2024 16:58:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rPrRa-00019A-BQ for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2024 16:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rPrRa-0006AL-Fa for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2024 16:58:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jan 2024 21:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68244 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170544224923647 (code B ref -1); Tue, 16 Jan 2024 21:58:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Jan 2024 21:57:29 +0000 Original-Received: from localhost ([127.0.0.1]:49904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPrR3-00069K-4O for submit@debbugs.gnu.org; Tue, 16 Jan 2024 16:57:29 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:43428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPrR0-000695-Dw for submit@debbugs.gnu.org; Tue, 16 Jan 2024 16:57:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPrQu-0001gY-1j for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2024 16:57:20 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPrQs-00015t-Ne for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2024 16:57:19 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rPrQp-0001Ml-IO for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2024 22:57:15 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278363 Archived-At: On Mon 15 Jan 2024, Mattias Engdegård wrote: > 15 jan. 2024 kl. 13.31 skrev Eli Zaretskii : > >>> Bisect identifies this as the bad commit: >>> d3cefd3e9835 ("Leaner hash table dumping and thawing") > > Thank you, I can reproduce the (or at least an) assertion failure in this > commit. However it's probably a ghost error: although I've tried to make sure > that there is a correct build at each point, there have been a lot of work > going on rearranging things for correctness and clarity, and apparently I > never built this particular one with checking enabled the last time. > > However this assertion should be removed by the next commit so the error is > very short-lived (and it's just an over-zealous assertion, not an actual > flaw). What problems do you observe when building master? > > (And yes, I should update some hashes in pdumper.c; it's been a while.) I bisected from newer master to get to that point. Bootstrapping master commit f19f5604deb7 ("Update pdumper hashes for buffer and Lisp_Hash_Table") is still failing, and trying to continue the buid by retrying after that is glacially slow, so something is badly broken at that point. Note that the same commit bootstrapped after "git clean -xdf" still has multiple backtraces when building without ENABLE_CHECKING. AndyM