all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: me@linj.tech, 68810@debbugs.gnu.org
Subject: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary
Date: Tue, 30 Jan 2024 14:27:07 +0200	[thread overview]
Message-ID: <86mssn2ehw.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmmueusuTJQAQHxA-JT02zAw=o-R4OY5nU55r-H7oHrm_Q@mail.gmail.com> (message from Stefan Kangas on Mon, 29 Jan 2024 19:39:54 -0500)

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Mon, 29 Jan 2024 19:39:54 -0500
> 
> Lin Jian via "Bug reports for GNU Emacs, the Swiss army knife of text
> editors" <bug-gnu-emacs@gnu.org> writes:
> 
> > Recommendation about setting transfer.fsckObjects of git to true can be
> > found in admin/notes/git-workflow and CONTRIBUTE.  In addition, it is
> > set in autogen.sh.
> >
> > This is triggered by a discussion[1] on emacs-devel.  The first commit
> > about this is cedd7cad092809a97c1ed7fb883b68fa844cea58 on 2016-01-31.
> > However, on 2016-02-04, another discussion[2] shows that git is secure
> > by default so setting this option is not necessary.
> >
> > What about removing this unnecessary recommendation?
> >
> > By the way, the same recommendation can be found on Emacswiki[3][4].
> >
> > [1]: https://lists.gnu.org/r/emacs-devel/2016-01/msg01802.html
> > [2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813157#29
> > [3]: https://www.emacswiki.org/emacs/GitQuickStartForEmacsDevs
> > [4]: https://www.emacswiki.org/emacs/GitForEmacsDevs
> 
> Are you sure?  The git documentation says:
> 
>     transfer.fsckObjects
> 
>     When fetch.fsckObjects or receive.fsckObjects are not set, the value
>     of this variable is used instead. Defaults to false.
> 
>     When set, the fetch or receive will abort in the case of a malformed
>     object or a link to a nonexistent object. In addition, various other
>     issues are checked for, including legacy issues (see fsck.<msg-id>),
>     and potential security issues like the existence of a .GIT directory
>     or a malicious .gitmodules file (see the release notes for v2.2.1
>     and v2.17.1 for details). Other sanity and security checks may be
>     added in future releases.
> 
> https://git-scm.com/docs/git-config#Documentation/git-config.txt-transferfsckObjects

And I have another question: does this setting cause any harm, or can
cause any harm in some situations?  IOW, what are the downsides of
using this setting?





  parent reply	other threads:[~2024-01-30 12:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29 23:16 bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary Lin Jian via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-30  0:39 ` Stefan Kangas
2024-01-30 11:57   ` Lin Jian via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-30 13:18     ` Eli Zaretskii
2024-01-30 13:53       ` Lin Jian via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-30 14:22         ` Eli Zaretskii
2024-01-30 20:49     ` Stefan Kangas
2024-01-30 12:27   ` Eli Zaretskii [this message]
2024-01-30 13:48     ` Lin Jian via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86mssn2ehw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=68810@debbugs.gnu.org \
    --cc=me@linj.tech \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.