From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68799: 30.0.50; emacs --fg-daemon fails silently if server-start fails Date: Tue, 13 Feb 2024 19:49:48 +0200 Message-ID: <86mss4p83n.fsf@gnu.org> References: <865xysr17s.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40151"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68799@debbugs.gnu.org, monnier@iro.umontreal.ca, jasonr@gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 13 18:52:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZwxk-000A9o-PE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Feb 2024 18:52:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZwxa-0001zl-91; Tue, 13 Feb 2024 12:52:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZwxZ-0001zL-99 for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 12:52:45 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZwxZ-0003PR-0W for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 12:52:45 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZwxq-0001Df-9M for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 12:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Feb 2024 17:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68799 X-GNU-PR-Package: emacs Original-Received: via spool by 68799-submit@debbugs.gnu.org id=B68799.17078467504627 (code B ref 68799); Tue, 13 Feb 2024 17:53:02 +0000 Original-Received: (at 68799) by debbugs.gnu.org; 13 Feb 2024 17:52:30 +0000 Original-Received: from localhost ([127.0.0.1]:46793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZwxJ-0001CZ-Ou for submit@debbugs.gnu.org; Tue, 13 Feb 2024 12:52:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZwxI-0001CI-2X for 68799@debbugs.gnu.org; Tue, 13 Feb 2024 12:52:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZwum-0002mz-DB; Tue, 13 Feb 2024 12:49:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=i/RxMNIPYTB1qgFcqsYWsahxeOR48JLU9V54rsiKVx8=; b=dg897z40mFV3 eE2n7EwrzmOss0fc+kEpL608UFBirKGvwHzoca1MhBuQ6OFCqyYk45iWUG1XqjIZND36b9DxEjxRz ZfyzBccsTvIQ4qOAqeU0E+iqvEGMhI9w4mDZWQrVvI2GtU+68V4ULHFXiSPdE34GbXevFyY8uFqC/ zNzA0gFLysZuLLe6QoxIc4mkQQMwycGf9SlfIJ5rRIqryfhiLoYYxh0nPki6uYJYgw8nPuwYCj6ix xnciISEEdZtC2jydKuCQqPKS54SCIT0GcILeGYkwrTE89C+LmkVCfA0D9+HlPPzG1sIf+b9V+jv86 /S1kEg9BnzB8WQC7FR5oJg==; In-Reply-To: (message from Spencer Baugh on Tue, 13 Feb 2024 12:37:30 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279971 Archived-At: > From: Spencer Baugh > Cc: 68799@debbugs.gnu.org, monnier@iro.umontreal.ca, jasonr@gnu.org > Date: Tue, 13 Feb 2024 12:37:30 -0500 > > >> So this check really wants to be something more like: > >> || ( IS_DAEMON && [something to check if Emacs is starting up]) > >> || (!IS_DAEMON && FRAME_INITIAL_P (sf)) > >> > >> Not sure what [something to check if Emacs is starting up] should be > >> though. > > > > after-init-time, I guess. But note that this still leaves a window > > between where that is set non-nil and starting the server. > > Oh, actually there is a DAEMON_RUNNING define which is exactly what we > want here. DAEMON_RUNNING just didn't exist at the time the check on > IS_DAEMON was added. Patch using DAEMON_RUNNING attached. Using DAEMON_RUNNING would mean any errors while starting the server will fail to show the explicit error message about that. That's a regression in my book. So I hope we can find a better solution.