From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Elijah G." Newsgroups: gmane.emacs.bugs Subject: bug#71159: [PATCH] Stipple support for MS Windows Date: Sat, 01 Jun 2024 13:04:11 -0600 Message-ID: <86mso44h90.fsf@gmail.com> References: <86cypcuhhk.fsf@gmail.com> <86jzjcgq00.fsf@gmail.com> <86sexydekl.fsf@gmail.com> <86o78kohzg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18435"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (windows-nt) Cc: 71159@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 01 21:06:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sDU3N-0004cb-UG for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Jun 2024 21:06:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDU36-0006vJ-Vi; Sat, 01 Jun 2024 15:05:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDU35-0006uK-3V for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 15:05:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDU34-0006vE-RK for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 15:05:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sDU3G-0005zm-6a for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 15:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Elijah G." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Jun 2024 19:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71159 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71159-submit@debbugs.gnu.org id=B71159.171726873123004 (code B ref 71159); Sat, 01 Jun 2024 19:06:02 +0000 Original-Received: (at 71159) by debbugs.gnu.org; 1 Jun 2024 19:05:31 +0000 Original-Received: from localhost ([127.0.0.1]:57413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDU2l-0005yx-7Q for submit@debbugs.gnu.org; Sat, 01 Jun 2024 15:05:31 -0400 Original-Received: from mail-oo1-f65.google.com ([209.85.161.65]:56329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDU2j-0005yl-PC for 71159@debbugs.gnu.org; Sat, 01 Jun 2024 15:05:30 -0400 Original-Received: by mail-oo1-f65.google.com with SMTP id 006d021491bc7-5b2ed25b337so2018119eaf.0 for <71159@debbugs.gnu.org>; Sat, 01 Jun 2024 12:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717268652; x=1717873452; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=wpnEjZsLuhmy7ZQCpGLSuUa03Ef4pEIPA+e9URtlc4o=; b=E3d6j8G03v+uY0kChOPV0yYSPK8uvy10VDx2e4gx40iz9a6l5nfjWBYszNqR8M0AGF xaWVQNxt+KyJBQ3VSJGLSYu5+4OTyOFCAd5WE/PvaTS3YeK/E2yqQ4+0Xu2DQVv7pH+V au4+w3fGi21CWlkoluhUxFGsRHAf1/p1fFhLlsT2cLWtrjYLu4x8KNHvsxFB9eB3dAjr yeXWbKxzmE1ofLmHlT7/oGwC6McPOlQAnBWCaGtY/MgIvUOvDSjPiBuK9xscpYo+wcZK PhdV6C6EoAOMl0COlW0a3wuPEpzxQClInskexUHHcr1bHj3Si/Ltaw0/OMIM+va23WRd G1KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717268652; x=1717873452; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wpnEjZsLuhmy7ZQCpGLSuUa03Ef4pEIPA+e9URtlc4o=; b=bokcF9jaUNbBwxeioTMIzdqvFaoMMFM/JkNpldfcaQtAM11Dudvfxp6tcta6T20Mh/ aTTHR0dwHYFZNQQrKTMWyHfgwfqfUoHpr8LpRqdNCGkCyihV7rnikz+ER9HNXuEetvXl 6Xn0UdlZLcekXJgdkb8M1nnP4MOcMpzpwDrhgEKyq8Q65sl5CmSToafgtN21+4SX2FRV /NSCrSUqsp5YZkvVJ4rmOcGyt9kk2L1Em3fii8mMZhYxidwP8DnpJQT+yobbmJQbGkbJ H8FK0fvDeRAxF85TUooP7pS/tYk63ly5hAptoUF1EemlAEWlHSUak4Gorfs9WBpAqosT T0Ug== X-Gm-Message-State: AOJu0YwJtGwypZNl0TWGJFultvifcUXQWf8KKoObaZPhkP9GLe5q6vKU v9gm/FlOLLqTii2rmAROPbUTB85qENmExnYxeQZ/+GxU2/CR9C+wtstWtBDN X-Google-Smtp-Source: AGHT+IG8p57J5w0t0tAv++i7qjKWoeAxY+EogdCwb2RBhyikdw606DAJsJSUXnixon0Jvd2As5vrOQ== X-Received: by 2002:a05:6871:7986:b0:250:66f0:2a67 with SMTP id 586e51a60fabf-2508bbb6de4mr5872702fac.37.1717268651683; Sat, 01 Jun 2024 12:04:11 -0700 (PDT) Original-Received: from LIBERO ([187.184.27.187]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-250850233f2sm1319621fac.30.2024.06.01.12.04.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jun 2024 12:04:11 -0700 (PDT) In-Reply-To: <86o78kohzg.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 01 Jun 2024 17:28:03 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286346 Archived-At: Eli Zaretskii writes: >> From: "Elijah G." >> Cc: Eli Zaretskii >> Date: Thu, 30 May 2024 18:12:42 -0600 >> >> I've updated the patch for delete all the conflicts generated by >> ae7d0e86b37eabc434c48f85f56df0a221e0e7c7 commit. > > Thanks, but is this the right patch? It includes a syntax error, > which GCC announces like this: > > image.c: In function 'image_create_bitmap_from_data': > image.c:627:26: error: expected ';' before 'do' > 627 | sa_avail = MAX_ALLOCA > | ^ > | ; > image.c:623:15: warning: variable 'sa_avail' set but not used [-Wunused-but-set-variable] > 623 | ptrdiff_t sa_avail; /* Used only for SAFE_NALLOCA. */ > | ^~~~~~~~ > Makefile:457: recipe for target `image.o' failed > make[2]: *** [image.o] Error 1 > > I'm guessing that you sent the wrong patch, because you couldn't have > built Emacs with this one. So, while the fix is trivial, I haven't > installed this, out of fear that other parts might be incorrect. I didn't know about that, i think it was an error that i didn't notice when i was generating the patch file, i was having troubles with my local repo. It should now be fixed in the new patch sent.