From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Avoiding 'with-temp-buffer' in tight loops Date: Fri, 09 Aug 2024 13:36:52 +0300 Message-ID: <86mslmkmnv.fsf@gnu.org> References: <605d068b-efa8-40c6-aaec-af1b3e1d1606@gmx.at> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38500"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 09 12:37:49 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1scN0G-0009o2-LQ for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Aug 2024 12:37:48 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1scMzT-0003pV-Ch; Fri, 09 Aug 2024 06:36:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1scMzR-0003pB-OC for emacs-devel@gnu.org; Fri, 09 Aug 2024 06:36:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1scMzQ-0000mf-Rg; Fri, 09 Aug 2024 06:36:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zQJEzTNQrh366HK5zGD5PQ6Qq0DNxMiBt4NyVNDdGrA=; b=fvkv3d9b1dOJ MptD5q9WElZPJ9LliKapcSfVKs/WXTV+QQFmqiBB77d4Aoiyd/LgcTFuXr/m08pXc0A1RKQyeSdnP wf391V1WVFmXlf16XvJ0J7hk9oclIDF70JgOWQctqOQiM2iOR4TUnIIq/L54VtAlr0Z0NnAKcLRqr 7+rvyIIdekgd4OSQ+uVdSivrhdO+YQh0jkSH57FKmYJS1bdieO8nuI2sIK43OL9AD3tk/LaEmkcUD ygS2KYe64IoFfDBp3/PZvSyf/wMDv4wqNZuN9+Myg9KxXoG9gpNnP3YMstzM6i4H/MW1GdJFgqCvE R080nQZkhw3gDVtlaPD/Tw==; In-Reply-To: <605d068b-efa8-40c6-aaec-af1b3e1d1606@gmx.at> (message from martin rudalics on Fri, 9 Aug 2024 10:30:42 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322562 Archived-At: > Date: Fri, 9 Aug 2024 10:30:42 +0200 > From: martin rudalics > > Ever since 'substitute-command-keys' has been transferred to help.el, > putting initial breakpoints in Fkill_buffer has become virtually > impossible. It should be possible to make the breakpoint conditional on the first character of a temporary buffer not being SPC. > Could we pretty please replace the > > (let ((keymap overriding-local-map) > (inhibit-modification-hooks t) > (orig-buf (current-buffer))) > (with-temp-buffer > > with something like > > (let* ((keymap overriding-local-map) > (inhibit-modification-hooks t) > (orig-buf (current-buffer)) > (buffer-name " *substitute-command-keys*") > (buffer (or (get-buffer buffer-name) > (generate-new-buffer buffer-name t)))) > (with-current-buffer buffer > (erase-buffer) This needs to be amended to support several threads calling substitute-command-keys, I think. An alternative for the above is to have substitute-command-keys bind some variable non-nil, and have a breakpoint be conditional on that variable's value. If this works, I think it's simpler and cleaner.