Re: Avoiding 'with-temp-buffer' in tight loops

[Eli Zaretskii <eliz@gnu.org>]

> Date: Fri, 9 Aug 2024 10:30:42 +0200
> From: martin rudalics <rudalics@gmx.at>
> 
> Ever since 'substitute-command-keys' has been transferred to help.el,
> putting initial breakpoints in Fkill_buffer has become virtually
> impossible.

It should be possible to make the breakpoint conditional on the first
character of a temporary buffer not being SPC.

> Could we pretty please replace the
> 
>      (let ((keymap overriding-local-map)
>            (inhibit-modification-hooks t)
>            (orig-buf (current-buffer)))
>        (with-temp-buffer
> 
> with something like
> 
>      (let* ((keymap overriding-local-map)
>             (inhibit-modification-hooks t)
>             (orig-buf (current-buffer))
> 	   (buffer-name " *substitute-command-keys*")
> 	   (buffer (or (get-buffer buffer-name)
> 		       (generate-new-buffer buffer-name t))))
>        (with-current-buffer buffer
> 	(erase-buffer)

This needs to be amended to support several threads calling
substitute-command-keys, I think.

An alternative for the above is to have substitute-command-keys bind
some variable non-nil, and have a breakpoint be conditional on that
variable's value.  If this works, I think it's simpler and cleaner.