From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72993: 31.0.50; 4f521fa14c18f57e5207bffd68e9f79454dccc79 breaks binding mode hooks in use-package Date: Tue, 03 Sep 2024 15:38:26 +0300 Message-ID: <86msko7vzx.fsf@gnu.org> References: <87mskpo5qc.fsf@stebalien.com> <86v7zd79ds.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25953"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72993@debbugs.gnu.org, steven@stebalien.com To: John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 03 14:39:43 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1slSoc-0006Bv-GA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Sep 2024 14:39:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1slSoL-0000Gx-33; Tue, 03 Sep 2024 08:39:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slSoG-0000GU-GH for bug-gnu-emacs@gnu.org; Tue, 03 Sep 2024 08:39:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1slSoG-0006xf-7D for bug-gnu-emacs@gnu.org; Tue, 03 Sep 2024 08:39:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=/aWphhVhmzoVqMMexzbuZAvpU95YFDyBwK1Z7na8pVY=; b=KRgmWpH+Yv4rEaI0AvDn4K0HZ3NQz3j9kH50w4ntZIn81XZXeZaz2TFgLp6xBONAZb2n8ViJUExz+Y4O3mXvUOTbcoQQoYbkVokB8REUzeJG6lj/ldS/ZjHViGz4711QKBXOKSD2b1IDh1BRCmNiRXL7SQSzxOfep6sCHO1yrrZO7W4HGQtr+QzmlvXbk2Y+/f7Cz59Ss/u+Ccdo03rylLasbSqFzHT/gWn+jMBjJeTXI/RMIbTE9xHqtqgmljCZkMdiQTDVxSnS9bHGiaJttbddESUk1Qv4pyl2NFjVzHm3fK6t4hn7cXNpopmpNXboXDNDvU4Kl4R0pBZi/EkpWA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1slSpG-0002UU-Cs for bug-gnu-emacs@gnu.org; Tue, 03 Sep 2024 08:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Sep 2024 12:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72993 X-GNU-PR-Package: emacs Original-Received: via spool by 72993-submit@debbugs.gnu.org id=B72993.17253671819540 (code B ref 72993); Tue, 03 Sep 2024 12:40:02 +0000 Original-Received: (at 72993) by debbugs.gnu.org; 3 Sep 2024 12:39:41 +0000 Original-Received: from localhost ([127.0.0.1]:59378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slSov-0002Tn-6J for submit@debbugs.gnu.org; Tue, 03 Sep 2024 08:39:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slSos-0002TV-S2 for 72993@debbugs.gnu.org; Tue, 03 Sep 2024 08:39:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slSnn-0006wD-2Y; Tue, 03 Sep 2024 08:38:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=/aWphhVhmzoVqMMexzbuZAvpU95YFDyBwK1Z7na8pVY=; b=D18g1m0i6lOCTxW12off QuoCO2ngDNJRs0W2RBMMQN/tm3ArIf6ne9PMkGjQxokUwj9ecI4SmcKTzJRYhtiBPBhed3dTS8MkD 2gixqRwGi5YWv2JR6LtI7MFt+vLOUHOK2xkF3l78KquPpSgj5DXGnK9TdybqvalyLiaSZHfNUV+Nt m0RTKX8Gx9OmQgI+yAcW2/lOzIHVx/Dh5ku1FzGChxZqbY8eH+wEBHSXvyKDp7s/0xDs5Un053taa IAyLWZ0NDaekbASenOhhnrYsr+zpMJSoN7wkJvAFww/8bnoa/3mBEnUJuCfIxAcPzej7Cg/V8i6bx jPNYH5K0v+QpBQ==; In-Reply-To: (message from John Wiegley on Mon, 02 Sep 2024 21:37:54 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291140 Archived-At: > From: John Wiegley > Cc: Steven Allen , 72993@debbugs.gnu.org > Date: Mon, 02 Sep 2024 21:37:54 -0700 > > >>>>> Eli Zaretskii writes: > > >> To reproduce: > >> > >> (use-package foo > >> :hook (eshell-mode . some-function)) > >> > >> Previously, `use-package' always appended `-hook' to the hook variable name. > >> After 4f521fa14c18f57e5207bffd68e9f79454dccc79, `use-package' only does > >> so if the passed variable name isn't bound. Unfortunately, this breaks > >> binding mode hooks, e.g.: > >> > >> :hook (some-mode . some-function) > >> > >> Because `some-mode' is usually bound. > > > John, any comments or suggestions? > > Sigh, I should have thought of this. There will be many such collisions, in > fact. > > Perhaps we should avoid auto -hook’ifying the variable name only if the name > does not already end in ‘-functions’? Either that, or maybe exempt FOO-mode from the boundp test.