From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master c86e7a29e78: ; Fix documentation of last change Date: Thu, 26 Sep 2024 17:25:53 +0300 Message-ID: <86msjua3v2.fsf@gnu.org> References: <172734990367.10758.14920367247781455923@vcs2.savannah.gnu.org> <20240926112504.2BD9EC4110A@vcs2.savannah.gnu.org> <86y13ea601.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33366"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 26 16:26:47 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1stpSA-0008SP-9j for ged-emacs-devel@m.gmane-mx.org; Thu, 26 Sep 2024 16:26:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stpRO-0000rV-OZ; Thu, 26 Sep 2024 10:25:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stpRN-0000kg-1H for emacs-devel@gnu.org; Thu, 26 Sep 2024 10:25:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stpRM-0006JK-Gp; Thu, 26 Sep 2024 10:25:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=S+wqhvzZmrPfoLYFdSMhMhJm+Z+J4eFNBLsJPU/sZq8=; b=lziDbfa8r53i vt2HaXH0IXBSDd2fuC5YKUD0nRsdVGyxlB1+vbWJJK8Sgfo7NBD+FsOsupSeCPbmpQVm6QDYiKI8J EeSwniOvju+224gXnZmOmM/Vygqdukxu6gzI/8lj/IQBQA5GKURERXdBGbru8pLTSMFUzB2yjyBZz /kYtSCZiuvwzFdnQn6yZtsEnWqfU3XJjATsc0rb4JCRKJlt+lkUOwwMUwKmy0w1iqmTEC/AR0CYwI akiNLxv+E+cPDiMo97AxHa6aanvTtpqXR28spaHVq2/RifmicSXuCmosD1qLccbRXqKWWy8Jxenso /vMqTJ0zTo7eEt97TdcfDA==; In-Reply-To: (message from Sean Whitton on Thu, 26 Sep 2024 15:19:58 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324110 Archived-At: > Date: Thu, 26 Sep 2024 15:19:58 +0100 > From: Sean Whitton > Cc: emacs-devel@gnu.org > > Hello, > > On Thu, Sep 26, 2024 at 04:39:42PM +0300, Eli Zaretskii wrote: > > > Date: Thu, 26 Sep 2024 12:44:57 +0100 > > > From: Sean Whitton > > > > > > > +++ > > > > *** New command 'diff-revert-and-kill-hunk' bound to C-c M-r. > > > > -This command reverse-applies the hunk at point, and then kills it. > > > > -This is useful in buffers generated by C-x v = and C-x v D. > > > > +This command reverts the hunk at point (i.e., applies the reverse of the > > > > +hunk), and then removes the hunk from the diffs. This is useful to undo > > > > +commits when you are in buffers generated by 'C-x v =' and 'C-x v D'. > > > > > > ^^^^^^^ > > > I think this should be "changes", right? > > > > Why do you think so? You mentioned VC commands, so I thought it was > > logical to talk, about commits. > > Right, but the two VCS commands I mention show uncommitted changes. Maybe by default, not in general. And there VC commands that show committed changes, which can also be reverted by this new command, right? So maybe we should say "undo commits or changes".