From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73838: 31.0.50; Problems in note_mouse_highlight if -nw Date: Wed, 16 Oct 2024 21:30:03 +0300 Message-ID: <86msj3q4t0.fsf@gnu.org> References: <86r08goy76.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4538"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73838@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 16 20:31:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t18nf-0000zo-I3 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Oct 2024 20:31:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t18nG-0000oI-Q9; Wed, 16 Oct 2024 14:30:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t18nD-0000o0-Nr for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2024 14:30:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t18nC-00056V-Ko for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2024 14:30:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=cQxptQMZGuM9bkASaIQGP3oe99FmYiDqB+Jv7GZC9Vo=; b=mVX22spSrv64HE9rFKxpGxpfZty20/ma0qvjtud8LgupZTzyPGv05EpesAuU2nUif0/KPdQRRk2c1wgdmCgcmNfwdR1FGZvNmZyFIXOUFmRrH3myONBcUeFiQnQPQoVLJfZ71P9qbPSQm/04D1a3s+SiPkc7hyyhfmHmMm0MLm08CVivZQmds2NJoi5tSQXFUcXNvWUNBiewtPE8Row6HCDbrNC0igZ2RiLbxFH8KL4tAaDyfD/qrrywCky/1ac7QISdYu6xGI/mALLauKrBkBrzBOAc1ve0E/ZNKi5HuRCbO3DJTa6H0Siq9PTRtoSapZclAppEjDSs2kDM5boa0w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t18nW-0006pz-7B for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2024 14:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2024 18:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73838 X-GNU-PR-Package: emacs Original-Received: via spool by 73838-submit@debbugs.gnu.org id=B73838.172910343326238 (code B ref 73838); Wed, 16 Oct 2024 18:31:02 +0000 Original-Received: (at 73838) by debbugs.gnu.org; 16 Oct 2024 18:30:33 +0000 Original-Received: from localhost ([127.0.0.1]:60467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t18n3-0006p7-6z for submit@debbugs.gnu.org; Wed, 16 Oct 2024 14:30:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t18n1-0006kR-AG for 73838@debbugs.gnu.org; Wed, 16 Oct 2024 14:30:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t18mb-000547-VD; Wed, 16 Oct 2024 14:30:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=cQxptQMZGuM9bkASaIQGP3oe99FmYiDqB+Jv7GZC9Vo=; b=nA8lYRq00PK/mESgZOxf NLwAKx9mw6ArD61J+Ix6Lo9Cgo6O2fOHzV/RCy/Fp6qdN8xKSELXo4iDR8+IumegQuA58zS3550Hf tf6k2dSqyXl1ozLaB4FdDjMHoNU9Zrrd7SEsxYQMZPvZvDNGNfa4LX7Sc2ZwGBwJE5Ka3pbxm0nj+ gky78p5VTQHoyHksuF1rKso69Gn5ubVGXFogDXmDJG5pGi3PQXL0q44JurKhEq7KAGtwxTD4AP+fa 8dCnCwMKYug7XxbPNWyWl9culkKd6/NLaWUeNFeMIxAGCh2m3pSxfQD+8IpRvFpfNyZs/Q9FFZV70 T3aZ0+4EYHe9PQ==; In-Reply-To: (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Wed, 16 Oct 2024 18:56:53 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293684 Archived-At: > From: Gerd Möllmann > Cc: 73838@debbugs.gnu.org > Date: Wed, 16 Oct 2024 18:56:53 +0200 > > Eli Zaretskii writes: > > > How can scroll bars happen on TTY frames? > > I'll try to answer this a bit more broadly: I'd like the code to be more > resilient, and not make implicit assumptions about the absence of of > features on ttys, which when false, leads to such hard to detect errors. > > Consider the internal border case. In master, FRAME_INTERNAL_BORDER > happens to return 0 in master. But that might change, if I ever get > setting internal borders to work for tty child frames, to draw the > border there. But then we need to audit a lot more than just these bits. E.g., who will guarantee that FRAME_WINDOW_P is always zero on TTY frames? More seriously, I think we should prefer functional tests to declarative tests. Which means not to assume that TTY frames can never have some display feature. Thus, IMO your suggestion is in a sense a step back, because it assumes that TTY frames can never have these decorations and can never have different cursor types. So my suggestion would be to do the opposite: understand why FRAME_OUTPUT_DATA segfaults when dereferenced on TTY frames, and fix that so that it doesn't.