From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73766: 30.0.91; (documentation 'pcase) can take several seconds Date: Fri, 18 Oct 2024 21:35:05 +0300 Message-ID: <86msj1mf8m.fsf@gnu.org> References: <86msj9y8u2.fsf@gnu.org> <86cyjxopl2.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12979"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73766@debbugs.gnu.org, yikai@z1k.dev, joaotavora@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 18 20:35:53 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t1rpI-0003CY-ID for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Oct 2024 20:35:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1rp9-0002Id-24; Fri, 18 Oct 2024 14:35:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1rp5-0002GE-Mo for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 14:35:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1rp5-0003Qi-E3 for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 14:35:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=NpVdeFzyMcFQZwJ2AdBv4eaK2JfreJuxZzJQKFF5fNE=; b=e8TDUvdGNUhH6rqHGLiauR6qDJ6HQMmb2rTIn8CEbtqQku8f6zIj3rqR9CbHLAaC8t03uT9wgaJrox87KtGKS+r2CTF+ZRlSUdnRTw5bAiG8E1DtfAALMHs6WldOjGTmqkmx59tIhLxZR+X/OlRMSY4ObI1fcPBpK0mzSzlZkU65xWj//Oo/kAnEEEioI9y32pPrGGYElYMIVG1ytem+M0q0ZG8xA2rsyluf+7Gk/vuHDBuL085rtCCKwL5qVzU0MRd2pOBdJrj857ubvV0iiuqWD9vQewcrbITLgXNCZSYV66v4oZ4FiWk0v1iIpO9aA1jWXwKCXQXKHjJ3/4WRDw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t1rpS-0005dS-0j for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 14:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Oct 2024 18:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73766 X-GNU-PR-Package: emacs Original-Received: via spool by 73766-submit@debbugs.gnu.org id=B73766.172927654021625 (code B ref 73766); Fri, 18 Oct 2024 18:36:01 +0000 Original-Received: (at 73766) by debbugs.gnu.org; 18 Oct 2024 18:35:40 +0000 Original-Received: from localhost ([127.0.0.1]:40033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1rp6-0005ch-4Y for submit@debbugs.gnu.org; Fri, 18 Oct 2024 14:35:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1rp4-0005bQ-1o for 73766@debbugs.gnu.org; Fri, 18 Oct 2024 14:35:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1roa-0003OO-Jv; Fri, 18 Oct 2024 14:35:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NpVdeFzyMcFQZwJ2AdBv4eaK2JfreJuxZzJQKFF5fNE=; b=XPyc35KIreKL YeOwUT0Vf5Kw3WpFDhHkLYuUu3zJuMgC2tU6j3Ay6ge709jcnr+mxworLtIaWOoX+vnvT0zfiaOKE hujnAwfQUD2tQHGF47vvhcjvHaI7n9+HFh5+iLdwCgaSanwTBRYTrK1LrIwfea9s1Wx9qlMJKZ608 2WWbhfLzemjwf8eaVjFNHIr1SEGulBqQtcUF3qWX9MbKBU4NvfjKouyOCKXvrOL2amP5d4sSXYdmh GeoVBYAM2SRjKAnsiZm0FWzQY/aQXXDs7Pij0c6iSmmW6bkdyRmMZO3G4GZGfmvbANW7GZrjBy0in zp0NxfpGiv3dDWuPzY1fuA==; In-Reply-To: (message from Stefan Monnier on Fri, 18 Oct 2024 13:04:54 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293809 Archived-At: > From: Stefan Monnier > Cc: yikai@z1k.dev, joaotavora@gmail.com, 73766@debbugs.gnu.org > Date: Fri, 18 Oct 2024 13:04:54 -0400 > > > I'd prefer the last alternative for emacs-30, but then you say: > > Thanks, will do. > > >> There's still a remaining performance issue for things like > >> `eldoc-mode`, admittedly where we'd really want it to be instantaneous, > >> but I think this should be fixed by making `eldoc` call `documentation` > >> in a special way to skips those useless computations (eldoc just wants > >> a "short doc" anyway). This affects other functions using the > >> `function-documentation` property in a similar way. > > Does it mean that this slowdown of eldoc was also caused by commit > > 052c2ce0284c5193c9d6768a45a9b3508af51230, and if so, does the patch > > you've shown previously (and which you consider not safe enough for > > emacs-30) solve the eldoc slowdown as well? > > What I meant is that the 4s slowdown affects both `C-h f` and eldoc, > and that the patch I sent which reduces it to 0.12s is IMO sufficient > for the `C-h f` case but may still make Emacs feel occasionally a bit > sluggish when eldoc hits this 0.12s. If the slowdown of eldoc is significant, maybe we will be better with reverting the change which introduced the regression on emacs-30, and then solving on master with your more thorough fix.