From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 73766@debbugs.gnu.org, yikai@z1k.dev, joaotavora@gmail.com
Subject: bug#73766: 30.0.91; (documentation 'pcase) can take several seconds
Date: Fri, 18 Oct 2024 21:35:05 +0300 [thread overview]
Message-ID: <86msj1mf8m.fsf@gnu.org> (raw)
In-Reply-To: <jwvo73hjqh6.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Fri, 18 Oct 2024 13:04:54 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: yikai@z1k.dev, joaotavora@gmail.com, 73766@debbugs.gnu.org
> Date: Fri, 18 Oct 2024 13:04:54 -0400
>
> > I'd prefer the last alternative for emacs-30, but then you say:
>
> Thanks, will do.
>
> >> There's still a remaining performance issue for things like
> >> `eldoc-mode`, admittedly where we'd really want it to be instantaneous,
> >> but I think this should be fixed by making `eldoc` call `documentation`
> >> in a special way to skips those useless computations (eldoc just wants
> >> a "short doc" anyway). This affects other functions using the
> >> `function-documentation` property in a similar way.
> > Does it mean that this slowdown of eldoc was also caused by commit
> > 052c2ce0284c5193c9d6768a45a9b3508af51230, and if so, does the patch
> > you've shown previously (and which you consider not safe enough for
> > emacs-30) solve the eldoc slowdown as well?
>
> What I meant is that the 4s slowdown affects both `C-h f` and eldoc,
> and that the patch I sent which reduces it to 0.12s is IMO sufficient
> for the `C-h f` case but may still make Emacs feel occasionally a bit
> sluggish when eldoc hits this 0.12s.
If the slowdown of eldoc is significant, maybe we will be better with
reverting the change which introduced the regression on emacs-30, and
then solving on master with your more thorough fix.
next prev parent reply other threads:[~2024-10-18 18:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 8:02 bug#73766: 30.0.91; (documentation 'pcase) can take several seconds Yikai Zhao
2024-10-12 9:22 ` Eli Zaretskii
2024-10-12 16:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-13 14:10 ` Yikai Zhao
2024-10-17 17:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 1:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 5:57 ` Eli Zaretskii
2024-10-18 7:08 ` Eli Zaretskii
2024-10-18 17:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-18 18:35 ` Eli Zaretskii [this message]
2024-10-18 20:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-27 10:48 ` Eli Zaretskii
2024-10-27 14:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86msj1mf8m.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=73766@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=yikai@z1k.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.