From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73533: [PATCH] Rewrite speedbar expansion for all descendants Date: Sat, 19 Oct 2024 20:41:37 +0300 Message-ID: <86msj0j8ha.fsf@gnu.org> References: <87y13blhu1.fsf@ice9.digital> <86a5fr5apb.fsf@gnu.org> <87v7yeeqig.fsf@ice9.digital> <87wmitfr8p.fsf@ice9.digital> <8734lhgfnn.fsf@ice9.digital> <87ttdm4f3d.fsf@ice9.digital> <86y12klery.fsf@gnu.org> <87a5f0c862.fsf@ice9.digital> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15258"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73533-done@debbugs.gnu.org To: Morgan Willcock Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 19 19:43:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2DTl-0003ki-8z for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Oct 2024 19:43:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2DTM-00054Z-F9; Sat, 19 Oct 2024 13:42:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2DTK-00053g-QL for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 13:42:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2DTK-0003Dq-GP for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 13:42:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=gGCGK5nkfbJaHxQ24bKc6qp9SfVvcfZnfbXwgcC32DI=; b=DV8SoDXHavHJzZOx5PcdMZYX8B673TgF39K6U/1VIFSmcGO3ElwhMq0c+vBZZCHHsUnFKUvI6H/BdGnAFZ2LWvKj6fceNcVxnhZ+bCsID9d1sekNK0o3ReVaYGG1U+0iQfl3lOs2nBx6fMXmqd+XbUGb0Izu4EXT8a2cKEoqW5UwoQCoElu/uNLWsiNMOx+VENwAJRHF2n1vR4nfgQtKYJxHKp7sZYFsS/bCFkgs9q9bl9yrLLGHJL92ZQmLJUD3TvwATgVDycu3GgtQzUUTgM+5/Gq9Bz/2btR04HqOib4ec7WbnkH3sOBIukSIY0PaZMV6USDV/qmv7vb88V1Uhg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t2DTi-0003Qj-E6 for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 13:43:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Oct 2024 17:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73533 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 73533@debbugs.gnu.org, eliz@gnu.org, morgan@ice9.digital Original-Received: via spool by 73533-done@debbugs.gnu.org id=D73533.172935973213109 (code D ref 73533); Sat, 19 Oct 2024 17:43:02 +0000 Original-Received: (at 73533-done) by debbugs.gnu.org; 19 Oct 2024 17:42:12 +0000 Original-Received: from localhost ([127.0.0.1]:44687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2DSt-0003PN-RA for submit@debbugs.gnu.org; Sat, 19 Oct 2024 13:42:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2DSr-0003P7-QV for 73533-done@debbugs.gnu.org; Sat, 19 Oct 2024 13:42:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2DSN-0003BK-FL; Sat, 19 Oct 2024 13:41:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gGCGK5nkfbJaHxQ24bKc6qp9SfVvcfZnfbXwgcC32DI=; b=ZtWTa9sGxds5 MXPrNQ0gheNRm5vG1XdPFTvCrCzEUdyHNOJfK07PTXteIJ7Fbyw3SJqfkaC1PR0QQMpdObZmKYpzJ +qbhyTy+vEVKB/GBO6ZrBKekrKaZse/AHkg/P89gC09TLiuSpE6g/usjEHCwtQPF9OaI8lonWj27b inBRXZJTpuxAPvRedti3oD4h3TPWmAcZltJBr3rYYF4ZZmXp/ASM+ABPrPmBFYNt4pjdvcnTSG4lZ 200Rk3XyLb0eb2xwazBWuKS18MS/MdJxf++WxVwYDDSzKg0uwIduasiechzdmb6lWbWgvm+q0MHpX B+yv7Fylbe3OzHDNhzufbw==; In-Reply-To: <87a5f0c862.fsf@ice9.digital> (message from Morgan Willcock on Sat, 19 Oct 2024 18:30:13 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293900 Archived-At: > From: Morgan Willcock > Cc: 73533@debbugs.gnu.org > Date: Sat, 19 Oct 2024 18:30:13 +0100 > > Eli Zaretskii writes: > > > There seems to be still a problem with some files, in that > > speedbar-expand-line-descendants takes a very long time, and if I > > interrupt it with C-g, I see nested DEFUNs, something that shouldn't > > happen, because DEFUNs are never nested. E.g., try this: > > > > $ cd /path/to/emacs/src > > $ ./emacs -Q > > M-x speedbar RET > > > > At this point you should see all the files in the Emacs src directory. > > Go to androidfns.c and type '['. After about 10 sec type C-g. You > > should see nested DEFUns in the Speedbar frame. > > > > Could you please look into this? > > This looks like an unrelated issue where the logic to modify the item > hierarchy does not make sense under certain conditions. It only seems > to trigger when particular limits are met, but the limits can be lowered > for an easier demonstration: > > (require 'speedbar) > (setq speedbar-tag-regroup-maximum-length 2) > (setq speedbar-tag-split-minimum-length 2) > > (speedbar-prefix-group-tag-hierarchy > '(("DEFUN" . 1) > ("DEFUN" . 5) > ("DEFUN" . 10))) > > => (("DEFUN" ("DEFUN" . 1) ("DEFUN" . 5) ("DEFUN" . 10))) > > i.e. speedbar-prefix-group-tag-hierarchy (which is meant to restructure > the Imenu data to make better use of the available space in the > Speedbar) is generating a new parent item which contains the items that > were meant to be inserted. > > It is probably best to open a separate bug report for this because > working out exactly how and why speedbar-prefix-group-tag-hierarchy > applies particular sorting actions will probably take someone a while. Done, and closing. Thanks.