bug#73914: 30.0.91; abort while reading invalid read syntax from minibuffer

bug#73914: 30.0.91; abort while reading invalid read syntax from minibuffer

[Jonathan Mitchell]

[-- Attachment #1.1: Type: text/plain, Size: 3608 bytes --]

Emacs 30.0.91 aborts while reading a lisp integer with invalid read
syntax from the M-: (eval-expression) minibuffer. I can't reproduce this
with Emacs 29.4, which correctly shows an invalid read syntax error message
in the minibuffer.

[Steps to repoduce]
1. Do a clean checkout the latest emacs-30 git branch
2. Build a --with-pgtk and debug build options
3. Start `emacs -Q' under gdb
4. Type `M-:' then something with invalid read syntax like `#0400'.


In GNU Emacs 30.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.43, cairo version 1.18.0) of 2024-10-20 built on toolbox
Repository revision: ac4151e0023f4bf17eb128036c006618332f1ac0
Repository branch: emacs-30
System Description: Fedora Linux 40 (Toolbx Container Image)

Configured using:
 'configure --with-pgtk --enable-checking=yes
 --enable-check-lisp-object-type 'CFLAGS=-O0 -g3''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY
PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny rfc822
mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util
time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils dired-aux cl-loaddefs cl-lib dired dired-loaddefs
mule-util compile text-property-search comint subr-x ansi-osc ansi-color
ring comp-run bytecomp byte-compile comp-common rx display-line-numbers
rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win
term/common-win touch-screen pgtk-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify
dynamic-setting system-font-setting font-render-setting cairo gtk pgtk
multi-tty move-toolbar make-network-process native-compile emacs)

Memory information:
((conses 16 94669 9244) (symbols 48 6895 0) (strings 32 26128 2330)
 (string-bytes 1 753579) (vectors 16 16588)
 (vector-slots 8 189667 10646) (floats 8 33 2) (intervals 56 533 0)
 (buffers 992 15))

[-- Attachment #1.2: Type: text/html, Size: 3951 bytes --]

[-- Attachment #2: backtrace.log --]
[-- Type: text/x-log, Size: 29468 bytes --]

Reading symbols from ./emacs...
SIGINT is used by the debugger.
Are you sure you want to change it? (y or n) [answered Y; input not from terminal]
DISPLAY = :0
WAYLAND_DISPLAY = wayland-0
TERM = xterm-256color
Breakpoint 1 at 0x57070c: file emacs.c, line 443.
(gdb) run -Q
Starting program: /var/home/kyle/src/emacs/src/emacs -Q

This GDB supports auto-downloading debuginfo from the following URLs:
  <https://debuginfod.fedoraproject.org/>
Enable debuginfod for this session? (y or [n]) 
Debuginfod has been disabled.
To make this setting permanent, add 'set debuginfod enabled off' to .gdbinit.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
[New Thread 0x7fffe28006c0 (LWP 52171)]
[New Thread 0x7fffe1e006c0 (LWP 52172)]
[New Thread 0x7fffe14006c0 (LWP 52173)]
[New Thread 0x7fffe0a006c0 (LWP 52174)]
[New Thread 0x7fffdbe006c0 (LWP 52175)]
[New Thread 0x7fffdb4006c0 (LWP 52176)]

character.h:230: Emacs fatal error: assertion failed: 0 <= c

Thread 1 "emacs" hit Breakpoint 1, terminate_due_to_signal (sig=6, backtrace_limit=2147483647) at emacs.c:443
443	  signal (sig, SIG_DFL);
Missing debuginfo, try: dnf debuginfo-install gtk3-3.24.43-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install zlib-ng-compat-2.1.7-2.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install pango-1.54.0-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install harfbuzz-8.5.0-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install atk-2.52.0-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install cairo-gobject-1.18.0-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install cairo-1.18.0-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install gdk-pixbuf2-2.42.10-8.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install glib2-2.80.3-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libtiff-4.6.0-2.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libjpeg-turbo-3.0.2-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libpng-1.6.40-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install giflib-5.2.2-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libwebp-1.3.2-5.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install alsa-lib-1.2.12-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install librsvg2-2.57.1-7.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install glibc-2.39-22.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libacl-2.3.2-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libattr-2.5.2-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install dbus-libs-1.14.10-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libxml2-2.12.8-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install gpm-libs-1.20.7-46.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install ncurses-libs-6.4-12.20240127.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libselinux-3.7-5.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install freetype-2.13.2-5.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install fontconfig-2.15.0-6.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libotf-0.9.16-4.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install gnutls-3.8.6-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install systemd-libs-255.13-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install gmp-6.2.1-8.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libgccjit-14.2.1-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libtree-sitter-0.22.5-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install sqlite-libs-3.45.1-2.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install fribidi-1.0.14-2.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libepoxy-1.5.10-6.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libXi-1.8.2-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libX11-1.8.10-2.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install at-spi2-atk-2.52.0-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libcloudproviders-0.3.5-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libtracker-sparql-3.7.3-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libwayland-client-1.23.0-2.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libXfixes-6.0.1-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libxkbcommon-1.6.0-2.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libwayland-cursor-1.23.0-2.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libwayland-egl-1.23.0-2.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libXext-1.3.6-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libXcursor-1.2.1-7.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libXdamage-1.1.6-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libXcomposite-0.4.6-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libXrandr-1.5.4-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libXinerama-1.1.5-6.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libthai-0.1.29-8.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install graphite2-1.3.14-15.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libXrender-0.9.11-6.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libxcb-1.17.0-2.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install pixman-0.43.4-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libmount-2.40.2-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libffi-3.4.4-7.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install pcre2-10.44-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libzstd-1.5.6-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install liblerc-4.0.0-6.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install jbigkit-libs-2.1-29.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libgcc-14.2.1-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install xz-libs-5.4.6-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install bzip2-libs-1.0.8-18.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libbrotli-1.1.0-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install p11-kit-0.25.5-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libidn2-2.3.7-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libunistring-1.1-7.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libtasn1-4.19.0-6.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install nettle-3.9.1-6.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libcap-2.69-8.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install lz4-libs-1.9.4-6.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libmpc-1.3.1-5.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install mpfr-4.2.1-4.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install at-spi2-core-2.52.0-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install json-glib-1.8.0-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libdatrie-0.2.13-9.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libXau-1.0.11-6.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libblkid-2.40.2-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install libstdc++-14.2.1-3.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install dconf-0.40.0-12.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install gvfs-client-1.54.3-1.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install rsvg-pixbuf-loader-2.57.1-7.fc40.x86_64
Missing debuginfo, try: dnf debuginfo-install gdk-pixbuf2-modules-2.42.10-8.fc40.x86_64
(gdb) bt full
#0  terminate_due_to_signal (sig=6, backtrace_limit=2147483647) at emacs.c:443
#1  0x000000000061c270 in die (msg=0x7cbd26 "0 <= c", file=0x7cbd1a "character.h", line=230) at alloc.c:8082
#2  0x0000000000690e07 in CHAR_STRING (c=-1, p=0x7fffffffba15 "\177")
    at /var/home/kyle/src/emacs/src/character.h:230
        len = 32767
#3  0x000000000069ab9c in read0 (readcharfun=XIL(0x140792d), locate_syms=false) at lread.c:4229
        n = 400
        c = -1
        p = 0x7fffffffba15 "\177"
        end = 0x7fffffffba50 "\340\274\377\377\377\177"
        ch = 48
        stackbuf = "#0400\177\000\000>@o\000\000\000\000\000\000\233\352\000\000\000\000\000\001\000\000\000\000\000\000\000\001\000\000\000\000\000\000\000(y@\001\000\000\000\000P\272\377\377\377\177\000\000\006\000\000\000\000\000\000"
        read_buffer = 0x7fffffffba10 "#0400\177"
        read_buffer_size = 64
        offset = 15418640
        heapbuf = 0x0
        base_pdl = {
          bytes = 960
        }
        base_sp = 0
        count = {
          bytes = 992
        }
        uninterned_symbol = false
        skip_shorthand = false
        obj = XIL(0x7fffffffba00)
        multibyte = true
        c = 35
#4  0x0000000000697647 in read_internal_start
    (stream=XIL(0x140792d), start=XIL(0), end=XIL(0), locate_syms=false) at lread.c:2772
        retval = XIL(0x140792d)
#5  0x00000000006972f1 in Fread (stream=XIL(0x140792d)) at lread.c:2683
#6  0x0000000000655b88 in funcall_subr (subr=0xe2db80 <Sread>, numargs=1, args=0x7fffffffbd90) at eval.c:3161
        argbuf = {XIL(0x64cdaf), XIL(0xe2db85), XIL(0x7fffffffbc80), XIL(0x64e120), XIL(0x5), XIL(0x1200e2db85), XIL(0xe2db85), XIL(0x7fffffffbc90)}
        a = 0x7fffffffbd90
        maxargs = 1
        fun = XIL(0x64d3d5)
#7  0x0000000000655589 in funcall_general (fun=XIL(0xe2db85), numargs=1, args=0x7fffffffbd90) at eval.c:3040
        original_fun = XIL(0xf510)
#8  0x0000000000655888 in Ffuncall (nargs=2, args=0x7fffffffbd88) at eval.c:3093
        count = {
          bytes = 928
        }
        val = XIL(0x140792d)
#9  0x00007ffff11510a4 in F726561642d2d65787072657373696f6e2d7472792d72656164_read__expression_try_read_0 ()
    at /var/home/kyle/src/emacs/src/../native-lisp/30.0.91-c27b4880/preloaded/simple-352bf6bc-57d3555d.eln
#10 0x0000000000655b6f in funcall_subr (subr=0x7ffff18d7748, numargs=0, args=0x7fffffffc250) at eval.c:3159
        argbuf = {XIL(0x7ffff18d774d), XIL(0x7fffffffbe10), XIL(0xea9b00), XIL(0), XIL(0), XIL(0x12ffffbe30), XIL(0x7ffff18d774d), XIL(0x7fffffffbe40)}
        a = 0x7fffffffc250
        maxargs = 0
        fun = XIL(0x64d3d5)
#11 0x0000000000655589 in funcall_general (fun=XIL(0x7ffff18d774d), numargs=0, args=0x7fffffffc250)
    at eval.c:3040
        original_fun = XIL(0x7ffff0a2dc18)
#12 0x0000000000655888 in Ffuncall (nargs=1, args=0x7fffffffc248) at eval.c:3093
        count = {
          bytes = 832
        }
        val = XIL(0x5780b3)
--Type <RET> for more, q to quit, c to continue without paging--c
#13 0x000000000064a22d in Ffuncall_interactively (nargs=1, args=0x7fffffffc248) at callint.c:250
        speccount = {
          bytes = 800
        }
#14 0x0000000000655dd8 in funcall_subr
    (subr=0xe286c0 <Sfuncall_interactively>, numargs=1, args=0x7fffffffc248) at eval.c:3184
        maxargs = -2
        fun = XIL(0x64d3d5)
#15 0x0000000000655589 in funcall_general (fun=XIL(0xe286c5), numargs=1, args=0x7fffffffc248) at eval.c:3040
        original_fun = XIL(0x9270)
#16 0x0000000000655888 in Ffuncall (nargs=2, args=0x7fffffffc240) at eval.c:3093
        count = {
          bytes = 768
        }
        val = make_fixnum(0)
#17 0x0000000000654987 in Fapply (nargs=3, args=0x7fffffffc240) at eval.c:2718
        i = 140737488339200
        funcall_nargs = 37488
        funcall_args = 0x0
        spread_arg = XIL(0)
        fun = XIL(0x9270)
        sa_avail = 16384
        sa_count = {
          bytes = 768
        }
        numargs = 0
        retval = XIL(0)
#18 0x000000000064a653 in Fcall_interactively
    (function=XIL(0x7ffff0a2dc18), record_flag=XIL(0), keys=XIL(0x7ffff1d76f05)) at callint.c:342
        funval = XIL(0x7ffff18d774d)
        events = 7
        env = XIL(0)
        speccount = {
          bytes = 736
        }
        arg_from_tty = false
        key_count = 1
        record_then_fail = false
        save_this_command = XIL(0x7ffff0a2dc18)
        save_this_original_command = XIL(0x7ffff0a2dc18)
        save_real_this_command = XIL(0x7ffff0a2dc18)
        save_last_command = XIL(0x102f0)
        prefix_arg = XIL(0)
        enable = XIL(0)
        up_event = XIL(0)
        form = XIL(0x7ffff18d77a3)
        specs = XIL(0)
        sa_avail = 15375104
        sa_count = {
          bytes = 140737488339648
        }
        string_len = 0
        string = 0x7fffffffc430 "\001"
        string_end = 0x0
        next_event = 140737245968205
        nargs = 15375104
        args = 0x7ffff18d7718
        visargs = 0xea9b00 <lispsym>
        varies = 0xf14121e8 <error: Cannot access memory at address 0xf14121e8>
        tem = 0x62ac9b <ASIZE+24> "H\213"
        val = XIL(0x62cbb5)
#19 0x00007ffff1155ad5 in F636f6d6d616e642d65786563757465_command_execute_0 ()
    at /var/home/kyle/src/emacs/src/../native-lisp/30.0.91-c27b4880/preloaded/simple-352bf6bc-57d3555d.eln
#20 0x0000000000655c1d in funcall_subr (subr=0x7ffff1d90920, numargs=1, args=0x7fffffffc888) at eval.c:3167
        argbuf = {XIL(0x7ffff0a2dc18), XIL(0), XIL(0), XIL(0), XIL(0), XIL(0x12ffffc5e0), XIL(0x7ffff1d90925), XIL(0x7fffffffc5f0)}
        a = 0x7fffffffc5a0
        maxargs = 4
        fun = XIL(0x64d3d5)
#21 0x0000000000655589 in funcall_general (fun=XIL(0x7ffff1d90925), numargs=1, args=0x7fffffffc888)
    at eval.c:3040
        original_fun = XIL(0x58b0)
#22 0x0000000000655888 in Ffuncall (nargs=2, args=0x7fffffffc880) at eval.c:3093
        count = {
          bytes = 704
        }
        val = XIL(0x58b0)
#23 0x000000000057945f in command_loop_1 () at keyboard.c:1550
        scount = {
          bytes = 672
        }
        cmd = XIL(0x7ffff0a2dc18)
        keybuf = {make_fixnum(13), XIL(0x7fffffffc808), XIL(0x4), XIL(0x7ffff14796c0), XIL(0x7ffff14796c5), XIL(0x7fffffffc700), XIL(0xea9b00), XIL(0), XIL(0), XIL(0x12ffffc720), XIL(0x7ffff14796c5), XIL(0x7fffffffc730), XIL(0x64d3d5), XIL(0x7ffff14796c5), XIL(0x4), XIL(0x7fffffffc808), XIL(0x64d3d5), XIL(0x7ffff05cfb90), XIL(0x7fffffffc7a0), XIL(0x655589), XIL(0x7fffffffc7a0), XIL(0x7fffffffc808), XIL(0x4), XIL(0x7ffff0aae0d0), XIL(0x7ffff1957bd0), XIL(0x7ffff0aae0d0), XIL(0x7ffff1d95cd0), XIL(0x62a59d), XIL(0x7ffff1d95cd0), XIL(0x7fffffffc7c0)}
        i = 1
        last_pt = 12
        prev_modiff = 14
        prev_buffer = 0x105e598
#24 0x0000000000651ac1 in internal_condition_case
    (bfun=0x578c07 <command_loop_1>, handlers=XIL(0x90), hfun=0x578104 <cmd_error>) at eval.c:1613
        val = XIL(0x7b90)
        c = 0x10022c0
#25 0x0000000000578808 in command_loop_2 (handlers=XIL(0x90)) at keyboard.c:1168
        val = XIL(0x7b90)
#26 0x0000000000650f13 in internal_catch (tag=XIL(0x7b90), func=0x5787e5 <command_loop_2>, arg=XIL(0x90))
    at eval.c:1292
        val = XIL(0x57509f)
        c = 0x1046690
#27 0x0000000000578735 in command_loop () at keyboard.c:1138
        val = XIL(0xebc6a0)
#28 0x0000000000577bdd in recursive_edit_1 () at keyboard.c:754
        count = {
          bytes = 608
        }
        val = XIL(0)
#29 0x00000000005cb608 in read_minibuf
    (map=XIL(0x7ffff195ae6b), initial=XIL(0), prompt=XIL(0x7ffff147cd24), expflag=true, histvar=XIL(0x7ffff0ac4ef0), histpos=make_fixnum(0), defalt=XIL(0), allow_props=false, inherit_input_method=false) at minibuf.c:905
        val = XIL(0)
        count = {
          bytes = 320
        }
        mini_frame = XIL(0xfe240d)
        ambient_dir = XIL(0x1048c34)
        minibuffer = XIL(0x105e59d)
        input_method = XIL(0)
        calling_frame = XIL(0xfe240d)
        calling_window = XIL(0xfe265d)
        enable_multibyte = XIL(0)
        pos = 0
        histstring = XIL(0x7fffffffcc60)
        histval = XIL(0)
        empty_minibuf = XIL(0x7ffff1c73f5d)
#30 0x00000000005cce21 in Fread_from_minibuffer
    (prompt=XIL(0x7ffff147cd24), initial_contents=XIL(0), keymap=XIL(0x7ffff195ae6b), read=XIL(0x30), hist=XIL(0x7ffff0ac4ef0), default_value=XIL(0), inherit_input_method=XIL(0)) at minibuf.c:1394
        histvar = XIL(0x7ffff0ac4ef0)
        histpos = make_fixnum(0)
        val = XIL(0x2f195adf8)
#31 0x00007ffff1150c99 in F726561642d2d65787072657373696f6e_read__expression_0 ()
    at /var/home/kyle/src/emacs/src/../native-lisp/30.0.91-c27b4880/preloaded/simple-352bf6bc-57d3555d.eln
#32 0x0000000000655baf in funcall_subr (subr=0x7ffff147cd70, numargs=1, args=0x7fffe2a00038) at eval.c:3163
        argbuf = {XIL(0x7ffff147cd24), XIL(0), XIL(0xea9b00), XIL(0), XIL(0), XIL(0x12ffffce80), XIL(0x7ffff147cd75), XIL(0x7fffffffce90)}
        a = 0x7fffffffce40
        maxargs = 2
        fun = XIL(0x6b0231)
#33 0x00000000006b1931 in exec_byte_code (fun=XIL(0x105e015), args_template=0, nargs=0, args=0x0)
    at bytecode.c:812
        call_nargs = 1
        call_fun = XIL(0x7ffff147cd75)
        count1 = {
          bytes = 256
        }
        val = XIL(0x7fffffffd160)
        call_args = 0x7fffe2a00038
        original_fun = XIL(0x7ffff05d3240)
        op = 1
        type = 17162261
        targets = {0x6b5252 <exec_byte_code+18033>, 0x6b5275 <exec_byte_code+18068>, 0x6b5277 <exec_byte_code+18070>, 0x6b5279 <exec_byte_code+18072>, 0x6b527b <exec_byte_code+18074>, 0x6b527b <exec_byte_code+18074>, 0x6b52d5 <exec_byte_code+18164>, 0x6b533e <exec_byte_code+18269>, 0x6b10d7 <exec_byte_code+1270>, 0x6b10d9 <exec_byte_code+1272>, 0x6b10db <exec_byte_code+1274>, 0x6b10dd <exec_byte_code+1276>, 0x6b10df <exec_byte_code+1278>, 0x6b10df <exec_byte_code+1278>, 0x6b10e5 <exec_byte_code+1284>, 0x6b10a6 <exec_byte_code+1221>, 0x6b1478 <exec_byte_code+2199>, 0x6b147a <exec_byte_code+2201>, 0x6b147c <exec_byte_code+2203>, 0x6b147e <exec_byte_code+2205>, 0x6b1480 <exec_byte_code+2207>, 0x6b1480 <exec_byte_code+2207>, 0x6b14b5 <exec_byte_code+2260>, 0x6b1486 <exec_byte_code+2213>, 0x6b164c <exec_byte_code+2667>, 0x6b164e <exec_byte_code+2669>, 0x6b1650 <exec_byte_code+2671>, 0x6b1652 <exec_byte_code+2673>, 0x6b1654 <exec_byte_code+2675>, 0x6b1654 <exec_byte_code+2675>, 0x6b1606 <exec_byte_code+2597>, 0x6b161d <exec_byte_code+2620>, 0x6b16f7 <exec_byte_code+2838>, 0x6b16f9 <exec_byte_code+2840>, 0x6b16fb <exec_byte_code+2842>, 0x6b16fd <exec_byte_code+2844>, 0x6b16ff <exec_byte_code+2846>, 0x6b16ff <exec_byte_code+2846>, 0x6b16b1 <exec_byte_code+2768>, 0x6b16c8 <exec_byte_code+2791>, 0x6b1a5a <exec_byte_code+3705>, 0x6b1a5c <exec_byte_code+3707>, 0x6b1a5e <exec_byte_code+3709>, 0x6b1a60 <exec_byte_code+3711>, 0x6b1a62 <exec_byte_code+3713>, 0x6b1a62 <exec_byte_code+3713>, 0x6b1a14 <exec_byte_code+3635>, 0x6b1a2b <exec_byte_code+3658>, 0x6b2201 <exec_byte_code+5664>, 0x6b2065 <exec_byte_code+5252>, 0x6b205c <exec_byte_code+5243>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b240e <exec_byte_code+6189>, 0x6b2587 <exec_byte_code+6566>, 0x6b25eb <exec_byte_code+6666>, 0x6b264d <exec_byte_code+6764>, 0x6b26b1 <exec_byte_code+6864>, 0x6b12e7 <exec_byte_code+1798>, 0x6b136b <exec_byte_code+1930>, 0x6b272c <exec_byte_code+6987>, 0x6b123b <exec_byte_code+1626>, 0x6b13cb <exec_byte_code+2026>, 0x6b2796 <exec_byte_code+7093>, 0x6b27f6 <exec_byte_code+7189>, 0x6b2836 <exec_byte_code+7253>, 0x6b2896 <exec_byte_code+7349>, 0x6b28f4 <exec_byte_code+7443>, 0x6b29cd <exec_byte_code+7660>, 0x6b2a0d <exec_byte_code+7724>, 0x6b2bab <exec_byte_code+8138>, 0x6b2d70 <exec_byte_code+8591>, 0x6b2db0 <exec_byte_code+8655>, 0x6b2df0 <exec_byte_code+8719>, 0x6b2e50 <exec_byte_code+8815>, 0x6b2eb0 <exec_byte_code+8911>, 0x6b2f10 <exec_byte_code+9007>, 0x6b2f8d <exec_byte_code+9132>, 0x6b2fd4 <exec_byte_code+9203>, 0x6b301b <exec_byte_code+9274>, 0x6b30d5 <exec_byte_code+9460>, 0x6b31d0 <exec_byte_code+9711>, 0x6b32cb <exec_byte_code+9962>, 0x6b33a2 <exec_byte_code+10177>, 0x6b3489 <exec_byte_code+10408>, 0x6b3570 <exec_byte_code+10639>, 0x6b3657 <exec_byte_code+10870>, 0x6b373e <exec_byte_code+11101>, 0x6b38b7 <exec_byte_code+11478>, 0x6b39b3 <exec_byte_code+11730>, 0x6b3b29 <exec_byte_code+12104>, 0x6b3be7 <exec_byte_code+12294>, 0x6b3ca5 <exec_byte_code+12484>, 0x6b4115 <exec_byte_code+13620>, 0x6b1f11 <exec_byte_code+4912>, 0x6b4168 <exec_byte_code+13703>, 0x6b41a8 <exec_byte_code+13767>, 0x6b425d <exec_byte_code+13948>, 0x6b42b0 <exec_byte_code+14031>, 0x6b4303 <exec_byte_code+14114>, 0x6b4343 <exec_byte_code+14178>, 0x6b437e <exec_byte_code+14237>, 0x6b43b9 <exec_byte_code+14296>, 0x6b43fc <exec_byte_code+14363>, 0x6b5252 <exec_byte_code+18033>, 0x6b444c <exec_byte_code+14443>, 0x6b4487 <exec_byte_code+14502>, 0x6b44c2 <exec_byte_code+14561>, 0x6b44fd <exec_byte_code+14620>, 0x6b4538 <exec_byte_code+14679>, 0x6b4573 <exec_byte_code+14738>, 0x6b1f11 <exec_byte_code+4912>, 0x6b5252 <exec_byte_code+18033>, 0x6b45b3 <exec_byte_code+14802>, 0x6b45fb <exec_byte_code+14874>, 0x6b463b <exec_byte_code+14938>, 0x6b467b <exec_byte_code+15002>, 0x6b46db <exec_byte_code+15098>, 0x6b473b <exec_byte_code+15194>, 0x6b477b <exec_byte_code+15258>, 0x6b47bb <exec_byte_code+15322>, 0x6b481b <exec_byte_code+15418>, 0x6b487b <exec_byte_code+15514>, 0x6b48db <exec_byte_code+15610>, 0x6b4916 <exec_byte_code+15669>, 0x6b5252 <exec_byte_code+18033>, 0x6b1e71 <exec_byte_code+4752>, 0x6b1abd <exec_byte_code+3804>, 0x6b11b4 <exec_byte_code+1491>, 0x6b1b54 <exec_byte_code+3955>, 0x6b1bcd <exec_byte_code+4076>, 0x6b1c43 <exec_byte_code+4194>, 0x6b1cb9 <exec_byte_code+4312>, 0x6b1e45 <exec_byte_code+4708>, 0x6b15be <exec_byte_code+2525>, 0x6b1ee5 <exec_byte_code+4868>, 0x6b1f3d <exec_byte_code+4956>, 0x6b1fc1 <exec_byte_code+5088>, 0x6b1ffa <exec_byte_code+5145>, 0x6b2242 <exec_byte_code+5729>, 0x6b22b0 <exec_byte_code+5839>, 0x6b232d <exec_byte_code+5964>, 0x6b2388 <exec_byte_code+6055>, 0x6b5252 <exec_byte_code+18033>, 0x6b4956 <exec_byte_code+15733>, 0x6b49d3 <exec_byte_code+15858>, 0x6b4a13 <exec_byte_code+15922>, 0x6b4a53 <exec_byte_code+15986>, 0x6b4a93 <exec_byte_code+16050>, 0x6b4ad3 <exec_byte_code+16114>, 0x6b4b33 <exec_byte_code+16210>, 0x6b4b93 <exec_byte_code+16306>, 0x6b4bf3 <exec_byte_code+16402>, 0x6b4c53 <exec_byte_code+16498>, 0x6b4de1 <exec_byte_code+16896>, 0x6b4e41 <exec_byte_code+16992>, 0x6b4ea1 <exec_byte_code+17088>, 0x6b4ee1 <exec_byte_code+17152>, 0x6b4fd2 <exec_byte_code+17393>, 0x6b50c3 <exec_byte_code+17634>, 0x6b5103 <exec_byte_code+17698>, 0x6b5143 <exec_byte_code+17762>, 0x6b3e32 <exec_byte_code+12881>, 0x6b3fc8 <exec_byte_code+13287>, 0x6b518a <exec_byte_code+17833>, 0x6b51ee <exec_byte_code+17933>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b295a <exec_byte_code+7545>, 0x6b3062 <exec_byte_code+9345>, 0x6b41ea <exec_byte_code+13833>, 0x6b53c2 <exec_byte_code+18401>, 0x6b542c <exec_byte_code+18507>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b54b3 <exec_byte_code+18642>, 0x6b552f <exec_byte_code+18766>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b5252 <exec_byte_code+18033>, 0x6b56d3 <exec_byte_code+19186> <repeats 64 times>}
        quitcounter = 1 '\001'
        bc = 0xe13090 <main_thread+496>
        top = 0x7fffe2a00030
        pc = 0x7ffff1dee431 "\303\b!B\207"
        bytestr = XIL(0x7ffff147cdec)
        vector = XIL(0x7ffff147cc35)
        maxdepth = make_fixnum(3)
        const_length = 4
        bytestr_length = 8
        vectorp = 0x7ffff147cc38
        max_stack = 3
        frame_base = 0x7fffe2a00030
        fp = 0x7fffe2a00048
        bytestr_data = 0x7ffff1dee42e "\301\302!\303\b!B\207"
        rest = false
        mandatory = 0
        nonrest = 0
        pushedargs = 0
        result = XIL(0x10)
#34 0x00000000006b09aa in Fbyte_code
    (bytestr=XIL(0x7ffff147cdec), vector=XIL(0x7ffff147cc35), maxdepth=make_fixnum(3)) at bytecode.c:329
        fun = XIL(0x105e015)
#35 0x00000000006543b3 in eval_sub (form=XIL(0x7ffff147cbf3)) at eval.c:2604
        i = 3
        maxargs = 3
        args_left = XIL(0)
        numargs = 3
        original_fun = XIL(0x7ffff05685f0)
        original_args = XIL(0x7ffff147cc03)
        count = {
          bytes = 224
        }
        fun = XIL(0xe2e845)
        val = XIL(0x656ead)
        funcar = XIL(0x7fffffffd4f0)
        argvals = {XIL(0x7ffff147cdec), XIL(0x7ffff147cc35), make_fixnum(3), XIL(0x7ffff17866b0), XIL(0), XIL(0xeb4ab0), XIL(0x64cdaf), XIL(0)}
#36 0x0000000000653ad0 in Feval (form=XIL(0x7ffff147cbf3), lexical=XIL(0)) at eval.c:2462
        count = {
          bytes = 192
        }
#37 0x000000000064a4ec in Fcall_interactively
    (function=XIL(0x7ffff05d3048), record_flag=XIL(0), keys=XIL(0x7ffff1d76f05)) at callint.c:325
        funval = XIL(0x7ffff147cb7d)
        events = 1
        env = XIL(0)
        speccount = {
          bytes = 160
        }
        arg_from_tty = false
        key_count = 1
        record_then_fail = false
        save_this_command = XIL(0x7ffff05d3048)
        save_this_original_command = XIL(0x7ffff05d3048)
        save_real_this_command = XIL(0x7ffff05d3048)
        save_last_command = XIL(0)
        prefix_arg = XIL(0)
        enable = XIL(0)
        up_event = XIL(0)
        form = XIL(0x7ffff147cbd3)
        specs = XIL(0x7ffff147cbf3)
        sa_avail = 15375104
        sa_count = {
          bytes = 140737488344880
        }
        string_len = 0
        string = 0x7fffffffd8a0 "\001"
        string_end = 0x0
        next_event = 140737241402237
        nargs = 15375104
        args = 0x7ffff147cb48
        visargs = 0xea9b00 <lispsym>
        varies = 0xf14121e8 <error: Cannot access memory at address 0xf14121e8>
        tem = 0x62ac9b <ASIZE+24> "H\213"
        val = XIL(0x62cbb5)
#38 0x00007ffff1155ad5 in F636f6d6d616e642d65786563757465_command_execute_0 ()
    at /var/home/kyle/src/emacs/src/../native-lisp/30.0.91-c27b4880/preloaded/simple-352bf6bc-57d3555d.eln
#39 0x0000000000655c1d in funcall_subr (subr=0x7ffff1d90920, numargs=1, args=0x7fffffffdcf8) at eval.c:3167
        argbuf = {XIL(0x7ffff05d3048), XIL(0), XIL(0), XIL(0), XIL(0), XIL(0x12ffffda50), XIL(0x7ffff1d90925), XIL(0x7fffffffda60)}
        a = 0x7fffffffda10
        maxargs = 4
        fun = XIL(0x64d3d5)
#40 0x0000000000655589 in funcall_general (fun=XIL(0x7ffff1d90925), numargs=1, args=0x7fffffffdcf8)
    at eval.c:3040
        original_fun = XIL(0x58b0)
#41 0x0000000000655888 in Ffuncall (nargs=2, args=0x7fffffffdcf0) at eval.c:3093
        count = {
          bytes = 128
        }
        val = XIL(0x58b0)
#42 0x000000000057945f in command_loop_1 () at keyboard.c:1550
        scount = {
          bytes = 96
        }
        cmd = XIL(0x7ffff05d3048)
        keybuf = {make_fixnum(134217786), make_fixnum(0), XIL(0x7fffffffdbc0), XIL(0x6309f0), XIL(0x200000030), XIL(0), XIL(0), XIL(0xafb0), XIL(0xff6064), XIL(0x7ffff1d95ce0), XIL(0x7ffff25a8363), XIL(0xafb0), XIL(0xea9b00), XIL(0x7ffff17866b0), XIL(0), XIL(0xeb4ab0), make_fixnum(1616272), XIL(0), XIL(0x7fffffffdc50), make_fixnum(1623382), XIL(0x7ffff17866b5), XIL(0x201002490), XIL(0), XIL(0xafb0), XIL(0x7ffff1d95ce0), XIL(0x7ffff181b52b), XIL(0x7ffff1c74483), XIL(0x7ffff1d95ce0), XIL(0x7fffffffdc90), XIL(0xafb0)}
        i = 1
        last_pt = 148
        prev_modiff = 16
        prev_buffer = 0x7ffff17866b0
#43 0x0000000000651ac1 in internal_condition_case
    (bfun=0x578c07 <command_loop_1>, handlers=XIL(0x90), hfun=0x578104 <cmd_error>) at eval.c:1613
        val = XIL(0x11dc0)
        c = 0x10914e0
#44 0x0000000000578808 in command_loop_2 (handlers=XIL(0x90)) at keyboard.c:1168
        val = XIL(0x11dc0)
#45 0x0000000000650f13 in internal_catch (tag=XIL(0x11dc0), func=0x5787e5 <command_loop_2>, arg=XIL(0x90))
    at eval.c:1292
        val = XIL(0x57509f)
        c = 0x10913b0
#46 0x00000000005787a1 in command_loop () at keyboard.c:1146
#47 0x0000000000577bdd in recursive_edit_1 () at keyboard.c:754
        count = {
          bytes = 32
        }
        val = XIL(0x7fffffffdeb0)
#48 0x0000000000577df0 in Frecursive_edit () at keyboard.c:837
        count = {
          bytes = 0
        }
        buffer = XIL(0)
#49 0x00000000005739d3 in main (argc=2, argv=0x7fffffffe178) at emacs.c:2635
        stack_bottom_variable = 0x0
        old_argc = 2
        dump_file = 0x0
        no_loadup = false
        junk = 0x0
        dname_arg = 0x0
        ch_to_dir = 0x0
        original_pwd = 0x0
        dump_mode = 0x0
        skip_args = 0
        temacs = 0x0
        attempt_load_pdump = true
        only_version = false
        rlim = {
          rlim_cur = 10022912,
          rlim_max = 18446744073709551615
        }
        lc_all = 0x0
        sockfd = -1
        module_assertions = false

Lisp Backtrace:
"read" (0xffffbd90)
"read--expression-try-read" (0xffffc250)
"funcall-interactively" (0xffffc248)
"command-execute" (0xffffc888)
"read--expression" (0xe2a00038)
"byte-code" (0xffffd470)
"command-execute" (0xffffdcf8)
(gdb) xbacktrace 
[Thread 0x7fffe14006c0 (LWP 52173) exited]
"read" (0xffffbd90)
"read--expression-try-read" (0xffffc250)
"funcall-interactively" (0xffffc248)
"command-execute" (0xffffc888)
"read--expression" (0xe2a00038)
"byte-code" (0xffffd470)
"command-execute" (0xffffdcf8)
(gdb) 

bug#73914: 30.0.91; abort while reading invalid read syntax from minibuffer

[Eli Zaretskii]

> From: Jonathan Mitchell <mitchell.jkyle@gmail.com>
> Date: Sun, 20 Oct 2024 14:00:47 -0500
> 
> Emacs 30.0.91 aborts while reading a lisp integer with invalid read
> syntax from the M-: (eval-expression) minibuffer. I can't reproduce this with Emacs 29.4, which correctly shows
> an invalid read syntax error message in the minibuffer.
> 
> [Steps to repoduce]
> 1. Do a clean checkout the latest emacs-30 git branch
> 2. Build a --with-pgtk and debug build options
> 3. Start `emacs -Q' under gdb
> 4. Type `M-:' then something with invalid read syntax like `#0400'.

Thanks, I installed a fix.

Stefan, Andrea, and Mattias: I'd appreciate your comments on the bug
and the fix, since this is on the release branch.

bug#73914: 30.0.91; abort while reading invalid read syntax from minibuffer

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> Thanks, I installed a fix.
>
> Stefan, Andrea, and Mattias: I'd appreciate your comments on the bug
> and the fix, since this is on the release branch.

Looks OK to me.  I'm not sufficiently familiar with how we usually
handle bumping into the EOF pseudo-character while reading to be sure
it's the very best way to deal with it, but it looks sane and safe.

BTW, in a non-debug build, the problem manifests itself in the detail of
the error we signal, where `M-: #0 RET` will signal an error
mentioning "#0\377" where the \377 is the "reification" of the -1
EOF pseudo-character.


        Stefan

bug#73914: 30.0.91; abort while reading invalid read syntax from minibuffer

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Jonathan Mitchell <mitchell.jkyle@gmail.com>,  Andrea Corallo
>  <acorallo@gnu.org>,  Mattias Engdegård
>  <mattias.engdegard@gmail.com>,
>   73914@debbugs.gnu.org
> Date: Sun, 20 Oct 2024 23:04:42 -0400
> 
> > Thanks, I installed a fix.
> >
> > Stefan, Andrea, and Mattias: I'd appreciate your comments on the bug
> > and the fix, since this is on the release branch.
> 
> Looks OK to me.  I'm not sufficiently familiar with how we usually
> handle bumping into the EOF pseudo-character while reading to be sure
> it's the very best way to deal with it, but it looks sane and safe.

Thanks.  At the very least, it seems to produce the same or very
similar behavior we had in Emacs 29 in these cases.

> BTW, in a non-debug build, the problem manifests itself in the detail of
> the error we signal, where `M-: #0 RET` will signal an error
> mentioning "#0\377" where the \377 is the "reification" of the -1
> EOF pseudo-character.

You mean, before the patch?

bug#73914: 30.0.91; abort while reading invalid read syntax from minibuffer

[Andrea Corallo]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Jonathan Mitchell <mitchell.jkyle@gmail.com>
>> Date: Sun, 20 Oct 2024 14:00:47 -0500
>> 
>> Emacs 30.0.91 aborts while reading a lisp integer with invalid read
>> syntax from the M-: (eval-expression) minibuffer. I can't reproduce this with Emacs 29.4, which correctly shows
>> an invalid read syntax error message in the minibuffer.
>> 
>> [Steps to repoduce]
>> 1. Do a clean checkout the latest emacs-30 git branch
>> 2. Build a --with-pgtk and debug build options
>> 3. Start `emacs -Q' under gdb
>> 4. Type `M-:' then something with invalid read syntax like `#0400'.
>
> Thanks, I installed a fix.
>
> Stefan, Andrea, and Mattias: I'd appreciate your comments on the bug
> and the fix, since this is on the release branch.

I'm no expert but the fix looks okay to me, also I don't have ATM any
better strategy in mind other than installing such a fix on the release
branch.

  Andrea

bug#73914: 30.0.91; abort while reading invalid read syntax from minibuffer

[Mattias Engdegård]

20 okt. 2024 kl. 21.42 skrev Eli Zaretskii <eliz@gnu.org>:

> Thanks, I installed a fix.
> 
> Stefan, Andrea, and Mattias: I'd appreciate your comments on the bug
> and the fix, since this is on the release branch.

This is fine.
Good timing too because I have a patch poised to refactor this part on master, fixing various other problems.

bug#73914: 30.0.91; abort while reading invalid read syntax from minibuffer

[Eli Zaretskii]

> From: Mattias Engdegård <mattias.engdegard@gmail.com>
> Date: Mon, 21 Oct 2024 11:49:30 +0200
> Cc: Jonathan Mitchell <mitchell.jkyle@gmail.com>,
>  Stefan Monnier <monnier@iro.umontreal.ca>,
>  Andrea Corallo <acorallo@gnu.org>,
>  73914@debbugs.gnu.org
> 
> 20 okt. 2024 kl. 21.42 skrev Eli Zaretskii <eliz@gnu.org>:
> 
> > Thanks, I installed a fix.
> > 
> > Stefan, Andrea, and Mattias: I'd appreciate your comments on the bug
> > and the fix, since this is on the release branch.
> 
> This is fine.
> Good timing too because I have a patch poised to refactor this part on master, fixing various other problems.

Thanks for the feedback.

bug#73914: 30.0.91; abort while reading invalid read syntax from minibuffer

[Eli Zaretskii]

> From: Andrea Corallo <acorallo@gnu.org>
> Cc: Jonathan Mitchell <mitchell.jkyle@gmail.com>,  Stefan Monnier
>  <monnier@iro.umontreal.ca>,  Mattias Engdegård
>  <mattias.engdegard@gmail.com>,  73914@debbugs.gnu.org
> Date: Mon, 21 Oct 2024 04:41:25 -0400
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Jonathan Mitchell <mitchell.jkyle@gmail.com>
> >> Date: Sun, 20 Oct 2024 14:00:47 -0500
> >> 
> >> Emacs 30.0.91 aborts while reading a lisp integer with invalid read
> >> syntax from the M-: (eval-expression) minibuffer. I can't reproduce this with Emacs 29.4, which correctly shows
> >> an invalid read syntax error message in the minibuffer.
> >> 
> >> [Steps to repoduce]
> >> 1. Do a clean checkout the latest emacs-30 git branch
> >> 2. Build a --with-pgtk and debug build options
> >> 3. Start `emacs -Q' under gdb
> >> 4. Type `M-:' then something with invalid read syntax like `#0400'.
> >
> > Thanks, I installed a fix.
> >
> > Stefan, Andrea, and Mattias: I'd appreciate your comments on the bug
> > and the fix, since this is on the release branch.
> 
> I'm no expert but the fix looks okay to me, also I don't have ATM any
> better strategy in mind other than installing such a fix on the release
> branch.

Thanks for the feedback.

bug#73914: 30.0.91; abort while reading invalid read syntax from minibuffer

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> BTW, in a non-debug build, the problem manifests itself in the detail of
>> the error we signal, where `M-: #0 RET` will signal an error
>> mentioning "#0\377" where the \377 is the "reification" of the -1
>> EOF pseudo-character.
>
> You mean, before the patch?

That's right, the \377 is present only before the patch.


        Stefan

bug#73914: 30.0.91; abort while reading invalid read syntax from minibuffer

[Eli Zaretskii]

> Cc: mattias.engdegard@gmail.com, 73914@debbugs.gnu.org,
>  monnier@iro.umontreal.ca, mitchell.jkyle@gmail.com
> Date: Mon, 21 Oct 2024 13:08:12 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > From: Andrea Corallo <acorallo@gnu.org>
> > Cc: Jonathan Mitchell <mitchell.jkyle@gmail.com>,  Stefan Monnier
> >  <monnier@iro.umontreal.ca>,  Mattias Engdegård
> >  <mattias.engdegard@gmail.com>,  73914@debbugs.gnu.org
> > Date: Mon, 21 Oct 2024 04:41:25 -0400
> > 
> > Eli Zaretskii <eliz@gnu.org> writes:
> > 
> > >> From: Jonathan Mitchell <mitchell.jkyle@gmail.com>
> > >> Date: Sun, 20 Oct 2024 14:00:47 -0500
> > >> 
> > >> Emacs 30.0.91 aborts while reading a lisp integer with invalid read
> > >> syntax from the M-: (eval-expression) minibuffer. I can't reproduce this with Emacs 29.4, which correctly shows
> > >> an invalid read syntax error message in the minibuffer.
> > >> 
> > >> [Steps to repoduce]
> > >> 1. Do a clean checkout the latest emacs-30 git branch
> > >> 2. Build a --with-pgtk and debug build options
> > >> 3. Start `emacs -Q' under gdb
> > >> 4. Type `M-:' then something with invalid read syntax like `#0400'.
> > >
> > > Thanks, I installed a fix.
> > >
> > > Stefan, Andrea, and Mattias: I'd appreciate your comments on the bug
> > > and the fix, since this is on the release branch.
> > 
> > I'm no expert but the fix looks okay to me, also I don't have ATM any
> > better strategy in mind other than installing such a fix on the release
> > branch.
> 
> Thanks for the feedback.

No further comments, so I'm now closing this bug.