From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#75018: 30.0.93; Dired icon missing in tool-bar Date: Sun, 22 Dec 2024 18:40:45 +0200 Message-ID: <86msgn6582.fsf@gnu.org> References: <87o714r2ky.fsf@pub.pink> <86bjx46wvs.fsf@gnu.org> <6bfb0822-f2e9-48d5-bcf3-0012fc432782@app.fastmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32824"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75018@debbugs.gnu.org To: "john muhl" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 22 17:42:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tPP2D-0008PA-H5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Dec 2024 17:42:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPP1r-000833-8V; Sun, 22 Dec 2024 11:42:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPP1o-00082s-6Z for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 11:42:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPP1m-00055D-U8 for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 11:42:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=cFBMhHE4nLGzFn1AHdTWGWFRg/RCl1pmKdy+e8Bkdb4=; b=aSgynxaNIr4B/01QVdGh6+zLBjL6uCwsswTOPpGzw7Hhah3lc0YIi4uo7zkQJDFBc45AStd4u1zpWISVnGH58GlQY7dszKHebF0CEsOWEvU0N/jc8cGZ0t4XtndIVmwqtUWGkv3To7l2ucxuFBB+pfGVt2rfdCJid0XAIVNb/AV5yYz918VMpvYagN0RkqP17KQBmOwU4f2StCYrY9vaiuBwxGCrW1z7TIPkhfShPq0weZCPg3WXmi/riXhihDyiRhe56MuTzzzgDenlJRAxTncJjEYG6phpRBWleuz1gpw6CNr6OdmYfootxZVQuWL0C9OuWFKR41MzAQVYy9swkA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tPP1l-0005av-N5 for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 11:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Dec 2024 16:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75018 X-GNU-PR-Package: emacs Original-Received: via spool by 75018-submit@debbugs.gnu.org id=B75018.173488571621487 (code B ref 75018); Sun, 22 Dec 2024 16:42:01 +0000 Original-Received: (at 75018) by debbugs.gnu.org; 22 Dec 2024 16:41:56 +0000 Original-Received: from localhost ([127.0.0.1]:51649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPP1g-0005aU-C2 for submit@debbugs.gnu.org; Sun, 22 Dec 2024 11:41:56 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPP1b-0005aA-Qj for 75018@debbugs.gnu.org; Sun, 22 Dec 2024 11:41:54 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPP1U-00052P-GJ; Sun, 22 Dec 2024 11:41:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cFBMhHE4nLGzFn1AHdTWGWFRg/RCl1pmKdy+e8Bkdb4=; b=DYVLWG0pIGo7 zGzvZiB469yRK1EFGe5FkBKtrBti6S4KJDjbDSIXzCXv0idPXuHN3JvrztodaqaorC15BfY+eCVqq LbjtlmOp08MPdd4aore/sziOllxOv2CTSh4y61gcKaEnMKCBcWG4p37nIk6qCaeAne6a4r8fviOyi Krj4RiQExjTVsLjE8xyhLENnctDl/7Sy0oayVIIBm1zK8N+QJjj1tsVfk9x6nNpFB1QczZY4kbw6p Pi47mk38mQoe9d/kYQ4EgjzYSD+oHuZ86Ep9WjebcoLHitgjTAJmpHnbrbGgrjVRxSJQ0NBm+oQpo 0WPsBxqxhvD/G7Q9wRTi2g==; In-Reply-To: <6bfb0822-f2e9-48d5-bcf3-0012fc432782@app.fastmail.com> (jm@pub.pink) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297608 Archived-At: > Date: Sun, 22 Dec 2024 09:32:23 -0600 > From: "john muhl" > Cc: 75018@debbugs.gnu.org > > On Sun, Dec 22, 2024, at 12:43 AM, Eli Zaretskii wrote: > >> From: john muhl > >> Date: Sat, 21 Dec 2024 18:19:57 -0600 > >> > >> The usual Dired icon is missing and instead shows up as a couple > >> of tiny triangles in the normal state and as a very generic file > >> icon on hover. Happens on emacs-30 and master and X11 and PGTK > >> builds. Lucid and Motif builds are unaffected. > > > > Where do the tool-bar icons come from in that build? They are not > > from the Emacs's etc/images/ directory, AFAICT. > > They are the stock GTK icons. On this system they are located in > /usr/share/icons/. The option x-gtk-stock-map is responsible for > the mapping between Emacs' etc/images/* and the system's > icons. The attached patch fixes it here. Can you explain the rationale for the patch and how it solves the problem? > > Can you post the Dired icon file from where your build takes them? > > Unfortunately I can't find those particular icons among the ~7000 > icons in the /usr/share/icons/ directory but they're probably in > there somewhere. If you run Emacs under GDB with a breakpoint in lookup_image, you should see all the tool-bar icons being loaded during startup. You can use the following GDB commands for the breakpoint, to see when the icon you are interested in gets loaded: pp spec This should show you the full absolute file name of the icon file Emacs is loading. The command "pp" is defined in src/.gdbinit, so if you don't start GDB from that directory, you will need to say (gdb) source /path/to/emacs/src/.gdbinit before running Emacs, to be able to use this useful command. > > Also, is this problem new in the last pretest, or did previous > > pretests behave the same? > > I tried 30.0.90 and 29.4 and they too are using the incorrect > icons. I suspect upgrading to Fedora 41 is what causes the > issue. Yes, that's usually the first suspect in such cases. Thanks.