From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 6a098c6 15/19: Add ivy-mode Date: Fri, 17 Apr 2015 23:25:01 +0200 Message-ID: <86lhhqwiqa.fsf@gmail.com> References: <20150416121807.21266.28456@vcs.savannah.gnu.org> <5531760C.80305@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1429305918 7272 80.91.229.3 (17 Apr 2015 21:25:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Apr 2015 21:25:18 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 17 23:25:13 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YjDlA-00078M-NQ for ged-emacs-devel@m.gmane.org; Fri, 17 Apr 2015 23:25:12 +0200 Original-Received: from localhost ([::1]:43559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjDlA-0006pm-0a for ged-emacs-devel@m.gmane.org; Fri, 17 Apr 2015 17:25:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjDl6-0006oG-MO for emacs-devel@gnu.org; Fri, 17 Apr 2015 17:25:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YjDl2-0004Tb-Mg for emacs-devel@gnu.org; Fri, 17 Apr 2015 17:25:08 -0400 Original-Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:38098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjDl2-0004Sd-Er for emacs-devel@gnu.org; Fri, 17 Apr 2015 17:25:04 -0400 Original-Received: by wiun10 with SMTP id n10so34069772wiu.1 for ; Fri, 17 Apr 2015 14:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=OMuvGlq2zwb1e0tfZdqByZzM1lKQGJ3xFNqsaeDz1/8=; b=e6EaObCiwfdwOM2oN5T3QFLGg5fMP/rWxf7mgqYdhq9icQJp4yuf233PoUYg4SgAds Zq+y7FYYQaedruNLaHnT/7YfnFMIhGKbMnMPyuHvs1W6N7AxmQEWLFfj11Nkwnreu4+N ln1SKx9moi/Y0/BzpvCaw84GYYR+WkNyYXmbz5IRG1g0auMy0mQfC5VgR4H1TccLiUPy jbpqGzhV1QbqBOS4SBv3JnkV/h6+iC7Fr3iqaBKzgQGSFz2L43ioBt78vdyuH7ooIrsD ivkqDwo2DVG84zRyyq2oa3DhdPHJquBv2N6/3Oogb5Xs7+AE9XeZKHHbGpNZUaFjdCh3 H4AQ== X-Received: by 10.194.19.35 with SMTP id b3mr9786274wje.24.1429305903864; Fri, 17 Apr 2015 14:25:03 -0700 (PDT) Original-Received: from olya-ThinkPad-Edge-E330 (ip20-32-209-87.adsl2.static.versatel.nl. [87.209.32.20]) by mx.google.com with ESMTPSA id ge8sm16227698wjc.32.2015.04.17.14.25.02 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 17 Apr 2015 14:25:03 -0700 (PDT) In-Reply-To: <5531760C.80305@yandex.ru> (Dmitry Gutov's message of "Sat, 18 Apr 2015 00:07:24 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185543 Archived-At: Dmitry Gutov writes: > On 04/16/2015 04:37 PM, Stefan Monnier wrote: >>> + (cond ((functionp collection) >>> + (error "Function as a collection unsupported")) >>> + ((hash-table-p collection) >>> + (error "Hash table as a collection unsupported")) >>> + ((listp (car collection)) >>> + (setq collection (mapcar #'car collection)))) >> [...] >>> + (setq completing-read-function 'ivy-completing-read) >> >> Since completion-tables in the form of a function are pretty common >> nowadays (and becoming every time more frequent), this is a real >> problem > > It also needs to support obarrays, to be useful with > e.g. `describe-function'. It already does, you're looking at an outdated version. The only thing that doesn't work so far is the completion in the directory of Info (regular Info nodes work fine). Also, I have yet to encounter a collection that is a hash table. Oleh