From: Andy Moreton <andrewjmoreton@gmail.com>
To: 21707@debbugs.gnu.org
Subject: bug#21707: include-file cleanup for src directory
Date: Tue, 20 Oct 2015 09:23:04 +0100 [thread overview]
Message-ID: <86lhay2bkn.fsf@gmail.com> (raw)
In-Reply-To: <56249650.5050804@cs.ucla.edu>
On Mon 19 Oct 2015, Paul Eggert wrote:
> Eli Zaretskii wrote:
>> I had compilation warnings and errors due to redisplaying_p and
>> cancel_hourglass not being declared in eval.c and lread.c. These two
>> files need to include dispextern.h to avoid that problem. (This isn't
>> Windows specific, so I wonder how it compiled for you.)
>
> It's a problem with platform-specific inclusions: xterm.h includes
> dispextern.h, but eval.c and lread.c don't include xterm.h on MS-Windows. I
> attempted to detect this sort of thing by hand without actually building on
> MS-Windows, but it's an easy thing to get wrong. Revised patch attached. Quite
> possibly there will be similar issues on other platforms, but they should be
> easy to fix once encountered.
This builds without problems on top of commit 10df0310cb8f for:
- mingw32 32bit
- mingw32 32bit with --wide-int
- mingw64 64bit
- cygwin 64bit
Looks good to me.
AndyM
next prev parent reply other threads:[~2015-10-20 8:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 7:05 bug#21707: include-file cleanup for src directory Paul Eggert
2015-10-19 7:23 ` Eli Zaretskii
2015-10-19 12:54 ` Andy Moreton
2015-10-19 13:23 ` Eli Zaretskii
2015-10-20 5:54 ` Paul Eggert
2015-10-20 8:23 ` Andy Moreton [this message]
2015-10-20 15:06 ` Eli Zaretskii
2015-10-20 15:06 ` Eli Zaretskii
2015-10-20 18:50 ` Paul Eggert
2015-10-20 19:15 ` Eli Zaretskii
2015-10-20 20:52 ` Paul Eggert
2015-10-20 19:28 ` Andy Moreton
2015-10-21 1:38 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86lhay2bkn.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=21707@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.