From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Brinkhoff Newsgroups: gmane.emacs.devel Subject: Re: master 158bb85 1/2: Fix issues regarding inotify file-notification Date: Tue, 28 Mar 2017 12:41:07 +0200 Organization: nocrew Message-ID: <86lgrpiszg.fsf@molnjunk.nocrew.org> References: <20170326074307.12949.89247@vcs0.savannah.gnu.org> <20170326074309.7883420194@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1490697743 24657 195.159.176.226 (28 Mar 2017 10:42:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Mar 2017 10:42:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 28 12:42:17 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csoZl-0004qs-CA for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 12:42:09 +0200 Original-Received: from localhost ([::1]:52281 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csoZr-0004N0-3I for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 06:42:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csoZ5-0004K1-NO for emacs-devel@gnu.org; Tue, 28 Mar 2017 06:41:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csoZ1-0007ml-GF for emacs-devel@gnu.org; Tue, 28 Mar 2017 06:41:27 -0400 Original-Received: from [195.159.176.226] (port=37580 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1csoZ1-0007jR-9p for emacs-devel@gnu.org; Tue, 28 Mar 2017 06:41:23 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1csoYp-0007hH-NU for emacs-devel@gnu.org; Tue, 28 Mar 2017 12:41:11 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 34 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:cyOw9QxnVzEHj6jtiTBx5ymL9oU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213439 Archived-At: Michael.Albinus@gmx.de wrote: > Fix issues regarding inotify file-notification > > Remove special code handling the inotify back-end. > * lisp/filenotify.el (file-notify--watch): New struct > representing a file-watch. > ... This commits adds a new testsuite failure when I run git clean -xfd && ./autogen.sh && make bootstrap && make check There's a new check in Finotify_add_watch that `Qdont_follow' is not a member of `aspect'. But `aspect' may be either a list or a symbol. The check fails when the testsuite passes in `t'. >From test/src/inotify-tests.log: Test inotify-file-watch-simple backtrace: (let ((temp-file (make-temp-file "inotify-simple")) (events 0)) (let (closure (t) nil (let ((fn-0 (function featurep)) (args-1 (list (quo ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc ert-run-test([cl-struct-ert-test inotify-file-watch-simple "Test if ert-run-or-rerun-test([cl-struct-ert--stats (not (tag :expensive-tes ert-run-tests((not (tag :expensive-test)) #[385 "\306^B\307\"\203G^@\2 ert-run-tests-batch((not (tag :expensive-test))) ert-run-tests-batch-and-exit((not (tag :expensive-test))) eval((ert-run-tests-batch-and-exit (quote (not (tag :expensive-test) command-line-1(("-L" ":." "-l" "ert" "-l" "src/inotify-tests.el" "-- command-line() normal-top-level() Test inotify-file-watch-simple condition: (wrong-type-argument listp t) FAILED 1/1 inotify-file-watch-simple