From: Lars Brinkhoff <lars@nocrew.org>
To: emacs-devel@gnu.org
Subject: Re: master 158bb85 1/2: Fix issues regarding inotify file-notification
Date: Tue, 28 Mar 2017 12:41:07 +0200 [thread overview]
Message-ID: <86lgrpiszg.fsf@molnjunk.nocrew.org> (raw)
In-Reply-To: 20170326074309.7883420194@vcs0.savannah.gnu.org
Michael.Albinus@gmx.de wrote:
> Fix issues regarding inotify file-notification
>
> Remove special code handling the inotify back-end.
> * lisp/filenotify.el (file-notify--watch): New struct
> representing a file-watch.
> ...
This commits adds a new testsuite failure when I run
git clean -xfd && ./autogen.sh && make bootstrap && make check
There's a new check in Finotify_add_watch that `Qdont_follow' is not a
member of `aspect'. But `aspect' may be either a list or a symbol. The
check fails when the testsuite passes in `t'.
From test/src/inotify-tests.log:
Test inotify-file-watch-simple backtrace:
(let ((temp-file (make-temp-file "inotify-simple")) (events 0)) (let
(closure (t) nil (let ((fn-0 (function featurep)) (args-1 (list (quo
ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
ert-run-test([cl-struct-ert-test inotify-file-watch-simple "Test if
ert-run-or-rerun-test([cl-struct-ert--stats (not (tag :expensive-tes
ert-run-tests((not (tag :expensive-test)) #[385 "\306^B\307\"\203G^@\2
ert-run-tests-batch((not (tag :expensive-test)))
ert-run-tests-batch-and-exit((not (tag :expensive-test)))
eval((ert-run-tests-batch-and-exit (quote (not (tag :expensive-test)
command-line-1(("-L" ":." "-l" "ert" "-l" "src/inotify-tests.el" "--
command-line()
normal-top-level()
Test inotify-file-watch-simple condition:
(wrong-type-argument listp t)
FAILED 1/1 inotify-file-watch-simple
next parent reply other threads:[~2017-03-28 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170326074307.12949.89247@vcs0.savannah.gnu.org>
[not found] ` <20170326074309.7883420194@vcs0.savannah.gnu.org>
2017-03-28 10:41 ` Lars Brinkhoff [this message]
2017-03-28 11:40 ` master 158bb85 1/2: Fix issues regarding inotify file-notification Michael Albinus
2017-03-28 12:31 ` Lars Brinkhoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86lgrpiszg.fsf@molnjunk.nocrew.org \
--to=lars@nocrew.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.