From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, Ergus <spacibba@aol.com>,
"53910@debbugs.gnu.org" <53910@debbugs.gnu.org>
Subject: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers
Date: Sun, 20 Feb 2022 20:56:15 +0200 [thread overview]
Message-ID: <86ley5e59s.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwvy228y3tb.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 18 Feb 2022 03:32:40 -0500")
>> If `context-menu-mode` is intended to work only on displayed buffers,
>> is it really important to ensure that it also doesn't fail on
>> non-window buffers?
>
> Yes, a :filter function in a keymap should not make such assumptions
> (nor have side-effects, as a general rule).
I can't find a way to prevent :filter from executing on context menus in help
buffers, so I just removed `help-buffer-under-preparation` from :filter.
next prev parent reply other threads:[~2022-02-20 18:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus>
2022-02-10 0:16 ` bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-10 7:08 ` Lars Ingebrigtsen
2022-02-10 8:54 ` Juri Linkov
2022-02-10 11:35 ` Lars Ingebrigtsen
2022-02-10 18:58 ` Juri Linkov
2022-02-11 8:31 ` martin rudalics
2022-02-11 8:40 ` Juri Linkov
2022-02-11 16:46 ` bug#53910: [External] : " Drew Adams
2022-02-12 17:05 ` Juri Linkov
2022-02-13 8:49 ` martin rudalics
2022-02-13 18:50 ` Juri Linkov
2022-02-17 19:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-17 19:30 ` Juri Linkov
2022-02-17 20:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-18 7:44 ` Juri Linkov
2022-02-18 8:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-20 18:56 ` Juri Linkov [this message]
2022-02-19 9:41 ` martin rudalics
2022-02-19 12:26 ` Eli Zaretskii
2022-02-19 17:07 ` martin rudalics
2022-02-19 17:22 ` Eli Zaretskii
2022-02-20 9:16 ` martin rudalics
2022-02-20 18:44 ` Juri Linkov
2022-02-21 9:07 ` martin rudalics
2022-02-22 17:10 ` Juri Linkov
2022-02-23 9:29 ` martin rudalics
2022-02-19 14:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-20 9:14 ` martin rudalics
2022-02-20 14:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-10 8:26 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ley5e59s.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=53910@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.