all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Rah Guzar <rahguzar@zohomail.eu>
Cc: 60426@debbugs.gnu.org
Subject: bug#60426: 29.0.60; Binding to outline-minor-mode-cycle-map correctly is unintuitive and hard
Date: Wed, 11 Jan 2023 21:38:05 +0200	[thread overview]
Message-ID: <86lem8vp42.fsf@mail.linkov.net> (raw)
In-Reply-To: <87fschrpqw.fsf@zohomail.eu> (Rah Guzar's message of "Wed, 11 Jan 2023 17:29:22 +0100")

> 1. I think  in the NEWS entry, "font-lock text property 'keymap'" should
>    probably just be "text property 'keymap'" i.e. why mention font-lock?

Thanks, now pushed to the emacs-29 branch with these corrections.

> 2. Since the implementation of `outline-minor-mode-cycle--bind` can change,
>    it is better to change the order of arguments and make `map` an actual
>    third argument. It is awkward to pass `nil` as the first argument and I
>    think that way the actual map key is bound to can be treated as an
>    implementation detail with `outline-minor-mode-cycle--bind` the official
>    way of binding keys on headings.

Even though it's like an "internal" function, I still hesitate to reorder
its arguments to not break user configs.  I'd rather add a new function
without two hyphens as the official way to use it in personal customization:

(defun outline-minor-mode-cycle-bind (key binding &optional filter map)
  (outline-minor-mode-cycle--bind map key binding &optional filter)

and declare `outline-minor-mode-cycle--bind` obsolete.





      reply	other threads:[~2023-01-11 19:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-30 11:12 bug#60426: 29.0.60; Binding to outline-minor-mode-cycle-map correctly is unintuitive and hard Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-05 17:45 ` Juri Linkov
2023-01-05 18:28   ` Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-10 18:59     ` Juri Linkov
2023-01-11 16:29       ` Rah Guzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-11 19:38         ` Juri Linkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86lem8vp42.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=60426@debbugs.gnu.org \
    --cc=rahguzar@zohomail.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.