From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: New unwind-protect byte-compiler warning Date: Tue, 04 Apr 2023 19:10:12 +0300 Organization: LINKOV.NET Message-ID: <86lej7wua3.fsf@mail.linkov.net> References: <0106E951-59EB-42C9-8F99-4182F56C6311@gmail.com> <87fs9ghr96.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11982"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 04 18:12:58 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjjHG-0002tJ-1p for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Apr 2023 18:12:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjjGU-0005KJ-0c; Tue, 04 Apr 2023 12:12:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjjGR-0005Js-Kr for emacs-devel@gnu.org; Tue, 04 Apr 2023 12:12:08 -0400 Original-Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjjGO-0000NE-Ji for emacs-devel@gnu.org; Tue, 04 Apr 2023 12:12:07 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 059B320008; Tue, 4 Apr 2023 16:11:58 +0000 (UTC) In-Reply-To: <87fs9ghr96.fsf@gmail.com> (Robert Pluim's message of "Tue, 04 Apr 2023 12:32:37 +0200") Received-SPF: pass client-ip=2001:4b98:dc4:8::227; envelope-from=juri@linkov.net; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305110 Archived-At: > This one: > > In mouse-wheel-global-text-scale: > mwheel.el:450:6: Warning: ‘unwind-protect’ without unwind forms > > is because weʼre protecting against errors from > `global-text-scale-adjust', but unlike `text-scale-{in,de}crease', > that doesnʼt signal an error when you reach the scale limit. > > Juri, we can add an unwind form of `t', or switch it to > `condition-case', whichever you prefer (Iʼm assuming perhaps > pessimistically that `global-text-scale-adjust' might signal in > future). Sorry, I don't recognize this function. And indeed, in the commit 1c3c8b6d58c9 I just moved it down.